Commit 121bdbf1 authored by Stefan Wahren's avatar Stefan Wahren Committed by Greg Kroah-Hartman

staging: vc04_services: Remove stack hog issue from TODO

Since there is no vchiq function listed by "make checkstack" anymore,
we can remove the stack hog issue from the TODO.
Signed-off-by: default avatarStefan Wahren <stefan.wahren@i2se.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent ae8d5f46
...@@ -40,17 +40,12 @@ should properly handle a module unload. This also includes that all ...@@ -40,17 +40,12 @@ should properly handle a module unload. This also includes that all
resouces must be freed (kthreads, debugfs entries, ...) and global resouces must be freed (kthreads, debugfs entries, ...) and global
variables avoided. variables avoided.
5) Fix stack hog 5) Cleanup logging mechanism
Running make checkstack shows that vchiq_dump_service_use_state() has
an extensive stack usage. Maybe other functions are also affected.
6) Cleanup logging mechanism
The driver should probably be using the standard kernel logging mechanisms The driver should probably be using the standard kernel logging mechanisms
such as dev_info, dev_dbg, and friends. such as dev_info, dev_dbg, and friends.
7) Documentation 6) Documentation
A short top-down description of this driver's architecture (function of A short top-down description of this driver's architecture (function of
kthreads, userspace, limitations) could be very helpful for reviewers. kthreads, userspace, limitations) could be very helpful for reviewers.
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment