Commit 12edb893 authored by Mengdong Lin's avatar Mengdong Lin Committed by Takashi Iwai

ALSA: hda - resume codecs in parallel

To reduce driver resume time, this patch resumes the codecs in parallel
if there are multiple codecs on the bus.

- The PM workqueue of bus is also used to parallel resuming multiple codecs.
- The work item 'pm_work' is renamed to 'suspend_work' to parallel suspending
  codecs.
- Add a work item 'resume_work' to parallel resuming codecs.
Signed-off-by: default avatarMengdong Lin <mengdong.lin@intel.com>
Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
parent 351892a8
...@@ -96,7 +96,8 @@ EXPORT_SYMBOL_HDA(snd_hda_delete_codec_preset); ...@@ -96,7 +96,8 @@ EXPORT_SYMBOL_HDA(snd_hda_delete_codec_preset);
#ifdef CONFIG_PM #ifdef CONFIG_PM
#define codec_in_pm(codec) ((codec)->in_pm) #define codec_in_pm(codec) ((codec)->in_pm)
static void hda_pm_work(struct work_struct *work); static void hda_suspend_work(struct work_struct *work);
static void hda_resume_work(struct work_struct *work);
static void hda_power_work(struct work_struct *work); static void hda_power_work(struct work_struct *work);
static void hda_keep_power_on(struct hda_codec *codec); static void hda_keep_power_on(struct hda_codec *codec);
#define hda_codec_is_power_on(codec) ((codec)->power_on) #define hda_codec_is_power_on(codec) ((codec)->power_on)
...@@ -1474,7 +1475,8 @@ int snd_hda_codec_new(struct hda_bus *bus, ...@@ -1474,7 +1475,8 @@ int snd_hda_codec_new(struct hda_bus *bus,
#ifdef CONFIG_PM #ifdef CONFIG_PM
spin_lock_init(&codec->power_lock); spin_lock_init(&codec->power_lock);
INIT_DELAYED_WORK(&codec->power_work, hda_power_work); INIT_DELAYED_WORK(&codec->power_work, hda_power_work);
INIT_WORK(&codec->pm_work, hda_pm_work); INIT_WORK(&codec->suspend_work, hda_suspend_work);
INIT_WORK(&codec->resume_work, hda_resume_work);
/* snd_hda_codec_new() marks the codec as power-up, and leave it as is. /* snd_hda_codec_new() marks the codec as power-up, and leave it as is.
* the caller has to power down appropriatley after initialization * the caller has to power down appropriatley after initialization
* phase. * phase.
...@@ -5116,13 +5118,21 @@ int snd_hda_check_amp_list_power(struct hda_codec *codec, ...@@ -5116,13 +5118,21 @@ int snd_hda_check_amp_list_power(struct hda_codec *codec,
} }
EXPORT_SYMBOL_HDA(snd_hda_check_amp_list_power); EXPORT_SYMBOL_HDA(snd_hda_check_amp_list_power);
static void hda_pm_work(struct work_struct *work) static void hda_suspend_work(struct work_struct *work)
{ {
struct hda_codec *codec = struct hda_codec *codec =
container_of(work, struct hda_codec, pm_work); container_of(work, struct hda_codec, suspend_work);
hda_call_codec_suspend(codec, false); hda_call_codec_suspend(codec, false);
} }
static void hda_resume_work(struct work_struct *work)
{
struct hda_codec *codec =
container_of(work, struct hda_codec, resume_work);
hda_call_codec_resume(codec);
}
#endif #endif
/* /*
...@@ -5700,7 +5710,7 @@ int snd_hda_suspend(struct hda_bus *bus) ...@@ -5700,7 +5710,7 @@ int snd_hda_suspend(struct hda_bus *bus)
cancel_delayed_work_sync(&codec->jackpoll_work); cancel_delayed_work_sync(&codec->jackpoll_work);
if (hda_codec_is_power_on(codec)) { if (hda_codec_is_power_on(codec)) {
if (bus->num_codecs > 1) if (bus->num_codecs > 1)
queue_work(bus->pm_wq, &codec->pm_work); queue_work(bus->pm_wq, &codec->suspend_work);
else else
hda_call_codec_suspend(codec, false); hda_call_codec_suspend(codec, false);
} }
...@@ -5724,8 +5734,15 @@ int snd_hda_resume(struct hda_bus *bus) ...@@ -5724,8 +5734,15 @@ int snd_hda_resume(struct hda_bus *bus)
struct hda_codec *codec; struct hda_codec *codec;
list_for_each_entry(codec, &bus->codec_list, list) { list_for_each_entry(codec, &bus->codec_list, list) {
hda_call_codec_resume(codec); if (bus->num_codecs > 1)
queue_work(bus->pm_wq, &codec->resume_work);
else
hda_call_codec_resume(codec);
} }
if (bus->num_codecs > 1)
flush_workqueue(bus->pm_wq);
return 0; return 0;
} }
EXPORT_SYMBOL_HDA(snd_hda_resume); EXPORT_SYMBOL_HDA(snd_hda_resume);
......
...@@ -921,7 +921,9 @@ struct hda_codec { ...@@ -921,7 +921,9 @@ struct hda_codec {
unsigned long power_off_acct; unsigned long power_off_acct;
unsigned long power_jiffies; unsigned long power_jiffies;
spinlock_t power_lock; spinlock_t power_lock;
struct work_struct pm_work; /* task to parallel multi-codec PM */ /* tasks to parallel multi-codec suspend/resume */
struct work_struct suspend_work;
struct work_struct resume_work;
#endif #endif
/* filter the requested power state per nid */ /* filter the requested power state per nid */
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment