Skip to content

L
linux
Commit 15e6392f authored by Namhyung Kim's avatar Namhyung Kim Committed by Arnaldo Carvalho de Melo
Browse files
Options

perf stat: Introduce get_ratio_color() helper 

The get_ratio_color() returns appropriate color string based on @ratio.
It helps reducing code duplication.

Cc: Ingo Molnar <mingo@elte.hu>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Link: http://lkml.kernel.org/r/1325000151-4463-2-git-send-email-namhyung@gmail.comSigned-off-by: default avatarNamhyung Kim <namhyung@gmail.com>
Signed-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
parent 29c9862f
Hide whitespace changes
Inline Side-by-side
Showing with 35 additions and 56 deletions
tools/perf/builtin-stat.c
View file @ 15e6392f
...@@ -578,6 +578,33 @@ static void nsec_printout(int cpu, struct perf_evsel *evsel, double avg) ...@@ -578,6 +578,33 @@ static void nsec_printout(int cpu, struct perf_evsel *evsel, double avg)
avg / avg_stats(&walltime_nsecs_stats)); avg / avg_stats(&walltime_nsecs_stats));
} }
/* used for get_ratio_color() */
enum grc_type {
GRC_STALLED_CYCLES_FE,
GRC_STALLED_CYCLES_BE,
GRC_CACHE_MISSES,
GRC_MAX_NR
};
static const char *get_ratio_color(enum grc_type type, double ratio)
{
static const double grc_table[GRC_MAX_NR][3] = {
[GRC_STALLED_CYCLES_FE] = { 50.0, 30.0, 10.0 },
[GRC_STALLED_CYCLES_BE] = { 75.0, 50.0, 20.0 },
[GRC_CACHE_MISSES] = { 20.0, 10.0, 5.0 },
};
const char *color = PERF_COLOR_NORMAL;
if (ratio > grc_table[type][0])
color = PERF_COLOR_RED;
else if (ratio > grc_table[type][1])
color = PERF_COLOR_MAGENTA;
else if (ratio > grc_table[type][2])
color = PERF_COLOR_YELLOW;
return color;
}
static void print_stalled_cycles_frontend(int cpu, struct perf_evsel *evsel __used, double avg) static void print_stalled_cycles_frontend(int cpu, struct perf_evsel *evsel __used, double avg)
{ {
double total, ratio = 0.0; double total, ratio = 0.0;
...@@ -588,13 +615,7 @@ static void print_stalled_cycles_frontend(int cpu, struct perf_evsel *evsel __us ...@@ -588,13 +615,7 @@ static void print_stalled_cycles_frontend(int cpu, struct perf_evsel *evsel __us
if (total) if (total)
ratio = avg / total * 100.0; ratio = avg / total * 100.0;
color = PERF_COLOR_NORMAL; color = get_ratio_color(GRC_STALLED_CYCLES_FE, ratio);
if (ratio > 50.0)
color = PERF_COLOR_RED;
else if (ratio > 30.0)
color = PERF_COLOR_MAGENTA;
else if (ratio > 10.0)
color = PERF_COLOR_YELLOW;
fprintf(output, " # "); fprintf(output, " # ");
color_fprintf(output, color, "%6.2f%%", ratio); color_fprintf(output, color, "%6.2f%%", ratio);
...@@ -611,13 +632,7 @@ static void print_stalled_cycles_backend(int cpu, struct perf_evsel *evsel __use ...@@ -611,13 +632,7 @@ static void print_stalled_cycles_backend(int cpu, struct perf_evsel *evsel __use
if (total) if (total)
ratio = avg / total * 100.0; ratio = avg / total * 100.0;
color = PERF_COLOR_NORMAL; color = get_ratio_color(GRC_STALLED_CYCLES_BE, ratio);
if (ratio > 75.0)
color = PERF_COLOR_RED;
else if (ratio > 50.0)
color = PERF_COLOR_MAGENTA;
else if (ratio > 20.0)
color = PERF_COLOR_YELLOW;
fprintf(output, " # "); fprintf(output, " # ");
color_fprintf(output, color, "%6.2f%%", ratio); color_fprintf(output, color, "%6.2f%%", ratio);
...@@ -634,13 +649,7 @@ static void print_branch_misses(int cpu, struct perf_evsel *evsel __used, double ...@@ -634,13 +649,7 @@ static void print_branch_misses(int cpu, struct perf_evsel *evsel __used, double
if (total) if (total)
ratio = avg / total * 100.0; ratio = avg / total * 100.0;
color = PERF_COLOR_NORMAL; color = get_ratio_color(GRC_CACHE_MISSES, ratio);
if (ratio > 20.0)
color = PERF_COLOR_RED;
else if (ratio > 10.0)
color = PERF_COLOR_MAGENTA;
else if (ratio > 5.0)
color = PERF_COLOR_YELLOW;
fprintf(output, " # "); fprintf(output, " # ");
color_fprintf(output, color, "%6.2f%%", ratio); color_fprintf(output, color, "%6.2f%%", ratio);
...@@ -657,13 +666,7 @@ static void print_l1_dcache_misses(int cpu, struct perf_evsel *evsel __used, dou ...@@ -657,13 +666,7 @@ static void print_l1_dcache_misses(int cpu, struct perf_evsel *evsel __used, dou
if (total) if (total)
ratio = avg / total * 100.0; ratio = avg / total * 100.0;
color = PERF_COLOR_NORMAL; color = get_ratio_color(GRC_CACHE_MISSES, ratio);
if (ratio > 20.0)
color = PERF_COLOR_RED;
else if (ratio > 10.0)
color = PERF_COLOR_MAGENTA;
else if (ratio > 5.0)
color = PERF_COLOR_YELLOW;
fprintf(output, " # "); fprintf(output, " # ");
color_fprintf(output, color, "%6.2f%%", ratio); color_fprintf(output, color, "%6.2f%%", ratio);
...@@ -680,13 +683,7 @@ static void print_l1_icache_misses(int cpu, struct perf_evsel *evsel __used, dou ...@@ -680,13 +683,7 @@ static void print_l1_icache_misses(int cpu, struct perf_evsel *evsel __used, dou
if (total) if (total)
ratio = avg / total * 100.0; ratio = avg / total * 100.0;
color = PERF_COLOR_NORMAL; color = get_ratio_color(GRC_CACHE_MISSES, ratio);
if (ratio > 20.0)
color = PERF_COLOR_RED;
else if (ratio > 10.0)
color = PERF_COLOR_MAGENTA;
else if (ratio > 5.0)
color = PERF_COLOR_YELLOW;
fprintf(output, " # "); fprintf(output, " # ");
color_fprintf(output, color, "%6.2f%%", ratio); color_fprintf(output, color, "%6.2f%%", ratio);
...@@ -703,13 +700,7 @@ static void print_dtlb_cache_misses(int cpu, struct perf_evsel *evsel __used, do ...@@ -703,13 +700,7 @@ static void print_dtlb_cache_misses(int cpu, struct perf_evsel *evsel __used, do
if (total) if (total)
ratio = avg / total * 100.0; ratio = avg / total * 100.0;
color = PERF_COLOR_NORMAL; color = get_ratio_color(GRC_CACHE_MISSES, ratio);
if (ratio > 20.0)
color = PERF_COLOR_RED;
else if (ratio > 10.0)
color = PERF_COLOR_MAGENTA;
else if (ratio > 5.0)
color = PERF_COLOR_YELLOW;
fprintf(output, " # "); fprintf(output, " # ");
color_fprintf(output, color, "%6.2f%%", ratio); color_fprintf(output, color, "%6.2f%%", ratio);
...@@ -726,13 +717,7 @@ static void print_itlb_cache_misses(int cpu, struct perf_evsel *evsel __used, do ...@@ -726,13 +717,7 @@ static void print_itlb_cache_misses(int cpu, struct perf_evsel *evsel __used, do
if (total) if (total)
ratio = avg / total * 100.0; ratio = avg / total * 100.0;
color = PERF_COLOR_NORMAL; color = get_ratio_color(GRC_CACHE_MISSES, ratio);
if (ratio > 20.0)
color = PERF_COLOR_RED;
else if (ratio > 10.0)
color = PERF_COLOR_MAGENTA;
else if (ratio > 5.0)
color = PERF_COLOR_YELLOW;
fprintf(output, " # "); fprintf(output, " # ");
color_fprintf(output, color, "%6.2f%%", ratio); color_fprintf(output, color, "%6.2f%%", ratio);
...@@ -749,13 +734,7 @@ static void print_ll_cache_misses(int cpu, struct perf_evsel *evsel __used, doub ...@@ -749,13 +734,7 @@ static void print_ll_cache_misses(int cpu, struct perf_evsel *evsel __used, doub
if (total) if (total)
ratio = avg / total * 100.0; ratio = avg / total * 100.0;
color = PERF_COLOR_NORMAL; color = get_ratio_color(GRC_CACHE_MISSES, ratio);
if (ratio > 20.0)
color = PERF_COLOR_RED;
else if (ratio > 10.0)
color = PERF_COLOR_MAGENTA;
else if (ratio > 5.0)
color = PERF_COLOR_YELLOW;
fprintf(output, " # "); fprintf(output, " # ");
color_fprintf(output, color, "%6.2f%%", ratio); color_fprintf(output, color, "%6.2f%%", ratio);
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment
GitLab Nexedi Edition | About GitLab | About Nexedi | 沪ICP备2021021310号-2 | 沪ICP备2021021310号-7