Commit 16afea02 authored by Art Haas's avatar Art Haas Committed by Linus Torvalds

[PATCH] Remove 'volatile' from spinlock_types

This is a resubmission of patches originally created by Ingo Molnar.
The link below is the initial (?) posting of the patch.

  http://marc.theaimsgroup.com/?l=linux-kernel&m=115217423929806&w=2

Remove 'volatile' from spinlock_types as it causes GCC to generate bad
code (see link) and locking should be used on kernel data.
Signed-off-by: default avatarArt Haas <ahaas@airmail.net>
Signed-off-by: default avatarLinus Torvalds <torvalds@osdl.org>
parent 3e577a80
...@@ -6,13 +6,13 @@ ...@@ -6,13 +6,13 @@
#endif #endif
typedef struct { typedef struct {
volatile unsigned int slock; unsigned int slock;
} raw_spinlock_t; } raw_spinlock_t;
#define __RAW_SPIN_LOCK_UNLOCKED { 1 } #define __RAW_SPIN_LOCK_UNLOCKED { 1 }
typedef struct { typedef struct {
volatile unsigned int lock; unsigned int lock;
} raw_rwlock_t; } raw_rwlock_t;
#define __RAW_RW_LOCK_UNLOCKED { RW_LOCK_BIAS } #define __RAW_RW_LOCK_UNLOCKED { RW_LOCK_BIAS }
......
...@@ -6,13 +6,13 @@ ...@@ -6,13 +6,13 @@
#endif #endif
typedef struct { typedef struct {
volatile unsigned int slock; unsigned int slock;
} raw_spinlock_t; } raw_spinlock_t;
#define __RAW_SPIN_LOCK_UNLOCKED { 1 } #define __RAW_SPIN_LOCK_UNLOCKED { 1 }
typedef struct { typedef struct {
volatile unsigned int lock; unsigned int lock;
} raw_rwlock_t; } raw_rwlock_t;
#define __RAW_RW_LOCK_UNLOCKED { RW_LOCK_BIAS } #define __RAW_RW_LOCK_UNLOCKED { RW_LOCK_BIAS }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment