switch fchmod() to fdget

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>

switch fchmod() to fdget
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
173c8401 · Al Viro · 7e3fb584 · 173c8401
Commit 173c8401 authored Aug 30, 2013 by Al Viro
Hide whitespace changes
Inline Side-by-side

Showing with 5 additions and 6 deletions

fs/open.c fs/open.c +5 -6

No files found.
--- a/fs/open.c
+++ b/fs/open.c
@@ -485,14 +485,13 @@ static int chmod_common(struct path *path, umode_t mode)
 SYSCALL_DEFINE2(fchmod, unsigned int, fd, umode_t, mode)
 {
-	struct file * file;
+	struct fd f = fdget(fd);
 	int err = -EBADF;
-	file = fget(fd);
+	if (f.file) {
-	if (file) {
+		audit_inode(NULL, f.file->f_path.dentry, 0);
-		audit_inode(NULL, file->f_path.dentry, 0);
+		err = chmod_common(&f.file->f_path, mode);
-		err = chmod_common(&file->f_path, mode);
+		fdput(f);
-		fput(file);
 	}
 	return err;
 }