Commit 17933db2 authored by Stephen Warren's avatar Stephen Warren Committed by Mark Brown

ASoC: tegra: use devm_ APIs in SPDIF driver

The devm_ APIs remove the need to manually clean up allocations,
thus removing some code.
Signed-off-by: default avatarStephen Warren <swarren@nvidia.com>
Signed-off-by: default avatarMark Brown <broonie@opensource.wolfsonmicro.com>
parent 7613c508
...@@ -245,11 +245,12 @@ static __devinit int tegra20_spdif_platform_probe(struct platform_device *pdev) ...@@ -245,11 +245,12 @@ static __devinit int tegra20_spdif_platform_probe(struct platform_device *pdev)
struct resource *mem, *memregion, *dmareq; struct resource *mem, *memregion, *dmareq;
int ret; int ret;
spdif = kzalloc(sizeof(struct tegra20_spdif), GFP_KERNEL); spdif = devm_kzalloc(&pdev->dev, sizeof(struct tegra20_spdif),
GFP_KERNEL);
if (!spdif) { if (!spdif) {
dev_err(&pdev->dev, "Can't allocate tegra20_spdif\n"); dev_err(&pdev->dev, "Can't allocate tegra20_spdif\n");
ret = -ENOMEM; ret = -ENOMEM;
goto exit; goto err;
} }
dev_set_drvdata(&pdev->dev, spdif); dev_set_drvdata(&pdev->dev, spdif);
...@@ -257,7 +258,7 @@ static __devinit int tegra20_spdif_platform_probe(struct platform_device *pdev) ...@@ -257,7 +258,7 @@ static __devinit int tegra20_spdif_platform_probe(struct platform_device *pdev)
if (IS_ERR(spdif->clk_spdif_out)) { if (IS_ERR(spdif->clk_spdif_out)) {
pr_err("Can't retrieve spdif clock\n"); pr_err("Can't retrieve spdif clock\n");
ret = PTR_ERR(spdif->clk_spdif_out); ret = PTR_ERR(spdif->clk_spdif_out);
goto err_free; goto err;
} }
mem = platform_get_resource(pdev, IORESOURCE_MEM, 0); mem = platform_get_resource(pdev, IORESOURCE_MEM, 0);
...@@ -274,19 +275,19 @@ static __devinit int tegra20_spdif_platform_probe(struct platform_device *pdev) ...@@ -274,19 +275,19 @@ static __devinit int tegra20_spdif_platform_probe(struct platform_device *pdev)
goto err_clk_put; goto err_clk_put;
} }
memregion = request_mem_region(mem->start, resource_size(mem), memregion = devm_request_mem_region(&pdev->dev, mem->start,
DRV_NAME); resource_size(mem), DRV_NAME);
if (!memregion) { if (!memregion) {
dev_err(&pdev->dev, "Memory region already claimed\n"); dev_err(&pdev->dev, "Memory region already claimed\n");
ret = -EBUSY; ret = -EBUSY;
goto err_clk_put; goto err_clk_put;
} }
spdif->regs = ioremap(mem->start, resource_size(mem)); spdif->regs = devm_ioremap(&pdev->dev, mem->start, resource_size(mem));
if (!spdif->regs) { if (!spdif->regs) {
dev_err(&pdev->dev, "ioremap failed\n"); dev_err(&pdev->dev, "ioremap failed\n");
ret = -ENOMEM; ret = -ENOMEM;
goto err_release; goto err_clk_put;
} }
spdif->playback_dma_data.addr = mem->start + TEGRA20_SPDIF_DATA_OUT; spdif->playback_dma_data.addr = mem->start + TEGRA20_SPDIF_DATA_OUT;
...@@ -298,7 +299,7 @@ static __devinit int tegra20_spdif_platform_probe(struct platform_device *pdev) ...@@ -298,7 +299,7 @@ static __devinit int tegra20_spdif_platform_probe(struct platform_device *pdev)
if (ret) { if (ret) {
dev_err(&pdev->dev, "Could not register DAI: %d\n", ret); dev_err(&pdev->dev, "Could not register DAI: %d\n", ret);
ret = -ENOMEM; ret = -ENOMEM;
goto err_unmap; goto err_clk_put;
} }
ret = tegra_pcm_platform_register(&pdev->dev); ret = tegra_pcm_platform_register(&pdev->dev);
...@@ -313,37 +314,23 @@ static __devinit int tegra20_spdif_platform_probe(struct platform_device *pdev) ...@@ -313,37 +314,23 @@ static __devinit int tegra20_spdif_platform_probe(struct platform_device *pdev)
err_unregister_dai: err_unregister_dai:
snd_soc_unregister_dai(&pdev->dev); snd_soc_unregister_dai(&pdev->dev);
err_unmap:
iounmap(spdif->regs);
err_release:
release_mem_region(mem->start, resource_size(mem));
err_clk_put: err_clk_put:
clk_put(spdif->clk_spdif_out); clk_put(spdif->clk_spdif_out);
err_free: err:
kfree(spdif);
exit:
return ret; return ret;
} }
static int __devexit tegra20_spdif_platform_remove(struct platform_device *pdev) static int __devexit tegra20_spdif_platform_remove(struct platform_device *pdev)
{ {
struct tegra20_spdif *spdif = dev_get_drvdata(&pdev->dev); struct tegra20_spdif *spdif = dev_get_drvdata(&pdev->dev);
struct resource *res;
tegra_pcm_platform_unregister(&pdev->dev); tegra_pcm_platform_unregister(&pdev->dev);
snd_soc_unregister_dai(&pdev->dev); snd_soc_unregister_dai(&pdev->dev);
tegra20_spdif_debug_remove(spdif); tegra20_spdif_debug_remove(spdif);
iounmap(spdif->regs);
res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
release_mem_region(res->start, resource_size(res));
clk_put(spdif->clk_spdif_out); clk_put(spdif->clk_spdif_out);
kfree(spdif);
return 0; return 0;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment