Commit 180a8c3d authored by Colin Ian King's avatar Colin Ian King Committed by David S. Miller

net: phy: mdio-bcm-unimac: remove redundant !timeout check

The check for zero timeout is always true at the end of the proceeding
while loop; the only other exit path in the loop is if the unimac MDIO
is not busy.  Remove the redundant zero timeout check and always
return -ETIMEDOUT on this timeout return path.
Signed-off-by: default avatarColin Ian King <colin.king@canonical.com>
Reviewed-by: default avatarFlorian Fainelli <f.fainelli@gmail.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 4f661542
...@@ -92,10 +92,7 @@ static int unimac_mdio_poll(void *wait_func_data) ...@@ -92,10 +92,7 @@ static int unimac_mdio_poll(void *wait_func_data)
usleep_range(1000, 2000); usleep_range(1000, 2000);
} while (--timeout); } while (--timeout);
if (!timeout) return -ETIMEDOUT;
return -ETIMEDOUT;
return 0;
} }
static int unimac_mdio_read(struct mii_bus *bus, int phy_id, int reg) static int unimac_mdio_read(struct mii_bus *bus, int phy_id, int reg)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment