Commit 198b618a authored by Giedrius Statkevičius's avatar Giedrius Statkevičius Committed by Darren Hart

asus-laptop: correct error handling in asus_read_brightness()

It is possible that acpi_evaluate_integer might fail and value would not be
set to any value so correct this defect by returning 0 in case of an
error. This is also the correct thing to return because the backlight
subsystem will print the old value of brightness in this case.
Signed-off-by: default avatarGiedrius Statkevičius <giedrius.statkevicius@gmail.com>
Signed-off-by: default avatarDarren Hart <dvhart@linux.intel.com>
parent 4f62568c
...@@ -775,8 +775,10 @@ static int asus_read_brightness(struct backlight_device *bd) ...@@ -775,8 +775,10 @@ static int asus_read_brightness(struct backlight_device *bd)
rv = acpi_evaluate_integer(asus->handle, METHOD_BRIGHTNESS_GET, rv = acpi_evaluate_integer(asus->handle, METHOD_BRIGHTNESS_GET,
NULL, &value); NULL, &value);
if (ACPI_FAILURE(rv)) if (ACPI_FAILURE(rv)) {
pr_warn("Error reading brightness\n"); pr_warn("Error reading brightness\n");
return 0;
}
return value; return value;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment