Commit 2217b249 authored by Alvin Lee's avatar Alvin Lee Committed by Alex Deucher

drm/amd/display: Update bounding box states (v2)

[Why]
We need to update each p-state in the bounding box

[How]
Update states when assigning values to clocks

v2: squash in patch to set min values (Alex)
Signed-off-by: default avatarAlvin Lee <alvin.lee2@amd.com>
Signed-off-by: default avatarJerry (Fangzhi) Zuo <Jerry.Zuo@amd.com>
Reviewed-by: default avatarHersen Wu <hersenxs.wu@amd.com>
Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
parent 7c8e0835
...@@ -168,17 +168,17 @@ struct _vcs_dpi_ip_params_st dcn3_0_ip = { ...@@ -168,17 +168,17 @@ struct _vcs_dpi_ip_params_st dcn3_0_ip = {
struct _vcs_dpi_soc_bounding_box_st dcn3_0_soc = { struct _vcs_dpi_soc_bounding_box_st dcn3_0_soc = {
.clock_limits = { .clock_limits = {
/* State 0 should have clocks set below WM set B minimums */
{ {
.state = 0, .state = 0,
}, .dispclk_mhz = 562.0,
/* State 1 is max */ .dppclk_mhz = 300.0,
{ .phyclk_mhz = 300.0,
.state = 1, .phyclk_d18_mhz = 667.0,
.dscclk_mhz = 405.6,
}, },
}, },
.min_dcfclk = 500.0, /* TODO: set this to actual min DCFCLK */ .min_dcfclk = 500.0, /* TODO: set this to actual min DCFCLK */
.num_states = 2, .num_states = 1,
.sr_exit_time_us = 12, .sr_exit_time_us = 12,
.sr_enter_plus_exit_time_us = 20, .sr_enter_plus_exit_time_us = 20,
.urgent_latency_us = 4.0, .urgent_latency_us = 4.0,
...@@ -204,6 +204,7 @@ struct _vcs_dpi_soc_bounding_box_st dcn3_0_soc = { ...@@ -204,6 +204,7 @@ struct _vcs_dpi_soc_bounding_box_st dcn3_0_soc = {
.round_trip_ping_latency_dcfclk_cycles = 191, .round_trip_ping_latency_dcfclk_cycles = 191,
.urgent_out_of_order_return_per_channel_bytes = 4096, .urgent_out_of_order_return_per_channel_bytes = 4096,
.channel_interleave_bytes = 256, .channel_interleave_bytes = 256,
.num_banks = 8,
.gpuvm_min_page_size_bytes = 4096, .gpuvm_min_page_size_bytes = 4096,
.hostvm_min_page_size_bytes = 4096, .hostvm_min_page_size_bytes = 4096,
.dram_clock_change_latency_us = 404, .dram_clock_change_latency_us = 404,
...@@ -2351,46 +2352,26 @@ static void dcn30_update_bw_bounding_box(struct dc *dc, struct clk_bw_params *bw ...@@ -2351,46 +2352,26 @@ static void dcn30_update_bw_bounding_box(struct dc *dc, struct clk_bw_params *bw
} }
for (i = 0; i < dcn3_0_soc.num_states; i++) { for (i = 0; i < dcn3_0_soc.num_states; i++) {
dcn3_0_soc.clock_limits[i].state = i;
dcn3_0_soc.clock_limits[i].dcfclk_mhz = dcfclk_mhz[i]; dcn3_0_soc.clock_limits[i].dcfclk_mhz = dcfclk_mhz[i];
dcn3_0_soc.clock_limits[i].fabricclk_mhz = dcfclk_mhz[i]; dcn3_0_soc.clock_limits[i].fabricclk_mhz = dcfclk_mhz[i];
dcn3_0_soc.clock_limits[i].dram_speed_mts = dram_speed_mts[i]; dcn3_0_soc.clock_limits[i].dram_speed_mts = dram_speed_mts[i];
}
}
/* Fill all states with max values of all other clocks */ /* Fill all states with max values of all other clocks */
for (i = 0; i < dcn3_0_soc.num_states; i++) {
/* Some clocks can come from bw_params, if so fill from bw_params[1], otherwise fill from dcn3_0_soc[1] */
/* Temporarily ignore bw_params values */
/* DTBCLK */
/*if (bw_params->clk_table.entries[0].dtbclk_mhz)
dcn3_0_soc.clock_limits[i].dtbclk_mhz = bw_params->clk_table.entries[1].dtbclk_mhz;
else*/
dcn3_0_soc.clock_limits[i].dtbclk_mhz = dcn3_0_soc.clock_limits[1].dtbclk_mhz;
/* DISPCLK */
/*if (bw_params->clk_table.entries[0].dispclk_mhz)
dcn3_0_soc.clock_limits[i].dispclk_mhz = bw_params->clk_table.entries[1].dispclk_mhz; dcn3_0_soc.clock_limits[i].dispclk_mhz = bw_params->clk_table.entries[1].dispclk_mhz;
else*/ dcn3_0_soc.clock_limits[i].dppclk_mhz = bw_params->clk_table.entries[1].dppclk_mhz;
dcn3_0_soc.clock_limits[i].dispclk_mhz = dcn3_0_soc.clock_limits[1].dispclk_mhz; dcn3_0_soc.clock_limits[i].phyclk_mhz = bw_params->clk_table.entries[1].phyclk_mhz;
dcn3_0_soc.clock_limits[i].dtbclk_mhz = dcn3_0_soc.clock_limits[0].dtbclk_mhz;
/* DPPCLK */ /* These clocks cannot come from bw_params, always fill from dcn3_0_soc[1] */
/*if (bw_params->clk_table.entries[0].dppclk_mhz) /* FCLK, PHYCLK_D18, SOCCLK, DSCCLK */
dcn3_0_soc.clock_limits[i].dppclk_mhz = bw_params->clk_table.entries[1].dppclk_mhz; dcn3_0_soc.clock_limits[i].phyclk_d18_mhz = dcn3_0_soc.clock_limits[0].phyclk_d18_mhz;
else*/ dcn3_0_soc.clock_limits[i].socclk_mhz = dcn3_0_soc.clock_limits[0].socclk_mhz;
dcn3_0_soc.clock_limits[i].dppclk_mhz = dcn3_0_soc.clock_limits[1].dppclk_mhz; dcn3_0_soc.clock_limits[i].dscclk_mhz = dcn3_0_soc.clock_limits[0].dscclk_mhz;
}
/* PHYCLK */ /* re-init DML with updated bb */
/*if (bw_params->clk_table.entries[0].phyclk_mhz) dml_init_instance(&dc->dml, &dcn3_0_soc, &dcn3_0_ip, DML_PROJECT_DCN30);
dcn3_0_soc.clock_limits[i].phyclk_mhz = bw_params->clk_table.entries[1].phyclk_mhz; if (dc->current_state)
else*/ dml_init_instance(&dc->current_state->bw_ctx.dml, &dcn3_0_soc, &dcn3_0_ip, DML_PROJECT_DCN30);
dcn3_0_soc.clock_limits[i].phyclk_mhz = dcn3_0_soc.clock_limits[1].phyclk_mhz;
/* These clocks cannot come from bw_params, always fill from dcn3_0_soc[1] */
/* FCLK, PHYCLK_D18, SOCCLK, DSCCLK */
dcn3_0_soc.clock_limits[i].phyclk_d18_mhz = dcn3_0_soc.clock_limits[1].phyclk_d18_mhz;
dcn3_0_soc.clock_limits[i].socclk_mhz = dcn3_0_soc.clock_limits[1].socclk_mhz;
dcn3_0_soc.clock_limits[i].dscclk_mhz = dcn3_0_soc.clock_limits[1].dscclk_mhz;
} }
/* re-init DML with updated bb */ /* re-init DML with updated bb */
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment