Commit 22a46eb4 authored by J. Bruce Fields's avatar J. Bruce Fields

nfsd: note inadequate stats locking

After 89a26b3d "nfsd: split DRC global spinlock into per-bucket
locks", there is no longer a single global spinlock to protect these
stats.

So, really we need to fix that.  For now, at least fix the comment.
Signed-off-by: default avatarJ. Bruce Fields <bfields@redhat.com>
parent 3ba75830
...@@ -142,8 +142,11 @@ struct nfsd_net { ...@@ -142,8 +142,11 @@ struct nfsd_net {
unsigned int drc_hashsize; unsigned int drc_hashsize;
/* /*
* Stats and other tracking of on the duplicate reply cache. All of these and * Stats and other tracking of on the duplicate reply cache.
* the "rc" fields in nfsdstats are protected by the cache_lock * These fields and the "rc" fields in nfsdstats are modified
* with only the per-bucket cache lock, which isn't really safe
* and should be fixed if we want the statistics to be
* completely accurate.
*/ */
/* total number of entries */ /* total number of entries */
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment