Commit 25bd8174 authored by Michael Halcrow's avatar Michael Halcrow Committed by Linus Torvalds

eCryptfs: Minor fixes to printk messages

The printk statements that result when the user does not have the
proper key available could use some refining.
Signed-off-by: default avatarMike Halcrow <mhalcrow@us.ibm.com>
Cc: Mike Halcrow <mhalcrow@us.ibm.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent 2830bfd6
...@@ -1527,9 +1527,10 @@ int ecryptfs_read_xattr_region(char *page_virt, struct inode *ecryptfs_inode) ...@@ -1527,9 +1527,10 @@ int ecryptfs_read_xattr_region(char *page_virt, struct inode *ecryptfs_inode)
size = ecryptfs_getxattr_lower(lower_dentry, ECRYPTFS_XATTR_NAME, size = ecryptfs_getxattr_lower(lower_dentry, ECRYPTFS_XATTR_NAME,
page_virt, ECRYPTFS_DEFAULT_EXTENT_SIZE); page_virt, ECRYPTFS_DEFAULT_EXTENT_SIZE);
if (size < 0) { if (size < 0) {
printk(KERN_ERR "Error attempting to read the [%s] " if (unlikely(ecryptfs_verbosity > 0))
"xattr from the lower file; return value = [%zd]\n", printk(KERN_INFO "Error attempting to read the [%s] "
ECRYPTFS_XATTR_NAME, size); "xattr from the lower file; return value = "
"[%zd]\n", ECRYPTFS_XATTR_NAME, size);
rc = -EINVAL; rc = -EINVAL;
goto out; goto out;
} }
......
...@@ -209,9 +209,10 @@ static int ecryptfs_open(struct inode *inode, struct file *file) ...@@ -209,9 +209,10 @@ static int ecryptfs_open(struct inode *inode, struct file *file)
if (!(mount_crypt_stat->flags if (!(mount_crypt_stat->flags
& ECRYPTFS_PLAINTEXT_PASSTHROUGH_ENABLED)) { & ECRYPTFS_PLAINTEXT_PASSTHROUGH_ENABLED)) {
rc = -EIO; rc = -EIO;
printk(KERN_WARNING "Attempt to read file that " printk(KERN_WARNING "Either the lower file "
"is not in a valid eCryptfs format, " "is not in a valid eCryptfs format, "
"and plaintext passthrough mode is not " "or the key could not be retrieved. "
"Plaintext passthrough mode is not "
"enabled; returning -EIO\n"); "enabled; returning -EIO\n");
mutex_unlock(&crypt_stat->cs_mutex); mutex_unlock(&crypt_stat->cs_mutex);
goto out_free; goto out_free;
......
...@@ -873,11 +873,11 @@ static int ecryptfs_setattr(struct dentry *dentry, struct iattr *ia) ...@@ -873,11 +873,11 @@ static int ecryptfs_setattr(struct dentry *dentry, struct iattr *ia)
if (!(mount_crypt_stat->flags if (!(mount_crypt_stat->flags
& ECRYPTFS_PLAINTEXT_PASSTHROUGH_ENABLED)) { & ECRYPTFS_PLAINTEXT_PASSTHROUGH_ENABLED)) {
rc = -EIO; rc = -EIO;
printk(KERN_WARNING "Attempt to read file that " printk(KERN_WARNING "Either the lower file "
"is not in a valid eCryptfs format, " "is not in a valid eCryptfs format, "
"and plaintext passthrough mode is not " "or the key could not be retrieved. "
"Plaintext passthrough mode is not "
"enabled; returning -EIO\n"); "enabled; returning -EIO\n");
mutex_unlock(&crypt_stat->cs_mutex); mutex_unlock(&crypt_stat->cs_mutex);
goto out; goto out;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment