Commit 26417ae4 authored by Dan Williams's avatar Dan Williams

libnvdimm, pfn: make 'resource' attribute only readable by root

For the same reason that /proc/iomem returns 0's for non-root readers
and acpi tables are root-only, make the 'resource' attribute for pfn
devices only readable by root. Otherwise we disclose physical address
information.

Fixes: f6ed58c7 ("libnvdimm, pfn: 'resource'-address and 'size'...")
Cc: <stable@vger.kernel.org>
Reported-by: default avatarDave Hansen <dave.hansen@linux.intel.com>
Signed-off-by: default avatarDan Williams <dan.j.williams@intel.com>
parent c1fb3542
...@@ -282,8 +282,16 @@ static struct attribute *nd_pfn_attributes[] = { ...@@ -282,8 +282,16 @@ static struct attribute *nd_pfn_attributes[] = {
NULL, NULL,
}; };
static umode_t pfn_visible(struct kobject *kobj, struct attribute *a, int n)
{
if (a == &dev_attr_resource.attr)
return 0400;
return a->mode;
}
struct attribute_group nd_pfn_attribute_group = { struct attribute_group nd_pfn_attribute_group = {
.attrs = nd_pfn_attributes, .attrs = nd_pfn_attributes,
.is_visible = pfn_visible,
}; };
static const struct attribute_group *nd_pfn_attribute_groups[] = { static const struct attribute_group *nd_pfn_attribute_groups[] = {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment