Commit 27b351c5 authored by Bill Pemberton's avatar Bill Pemberton Committed by Greg Kroah-Hartman

USB: quatech2: only write to the tty if the port is open.

The commit 2e124b4a removed the checks
that prevented qt2_process_read_urb() from trying to put chars into
ttys that weren't actually opened.  This resulted in 'tty is NULL'
warnings from flush_to_ldisc() when the device was used.

The devices use just one read urb for all ports.  As a result
qt2_process_read_urb() may be called with the current port set to a
port number that has not been opened.  Add a check if the port is open
before calling tty_flip_buffer_push().
Signed-off-by: default avatarBill Pemberton <wfp5p@virginia.edu>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 3f8bc5e4
...@@ -661,7 +661,9 @@ void qt2_process_read_urb(struct urb *urb) ...@@ -661,7 +661,9 @@ void qt2_process_read_urb(struct urb *urb)
__func__); __func__);
break; break;
} }
tty_flip_buffer_push(&port->port);
if (port_priv->is_open)
tty_flip_buffer_push(&port->port);
newport = *(ch + 3); newport = *(ch + 3);
...@@ -704,7 +706,8 @@ void qt2_process_read_urb(struct urb *urb) ...@@ -704,7 +706,8 @@ void qt2_process_read_urb(struct urb *urb)
tty_insert_flip_string(&port->port, ch, 1); tty_insert_flip_string(&port->port, ch, 1);
} }
tty_flip_buffer_push(&port->port); if (port_priv->is_open)
tty_flip_buffer_push(&port->port);
} }
static void qt2_write_bulk_callback(struct urb *urb) static void qt2_write_bulk_callback(struct urb *urb)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment