Commit 2948be5a authored by Minchan Kim's avatar Minchan Kim Committed by Linus Torvalds

mm: do not use double negation for testing page flags

With the discussion[1], I found it seems there are every PageFlags
functions return bool at this moment so we don't need double negation
any more.  Although it's not a problem to keep it, it makes future users
confused to use double negation for them, too.

Remove such possibility.

[1] https://marc.info/?l=linux-kernel&m=148881578820434

Frankly sepaking, I like every PageFlags to return bool instead of int.
It will make it clear.  AFAIR, Chen Gang had tried it but don't know why
it was not merged at that time.

http://lkml.kernel.org/r/1469336184-1904-1-git-send-email-chengang@emindsoft.com.cn

Link: http://lkml.kernel.org/r/1488868597-32222-1-git-send-email-minchan@kernel.orgSigned-off-by: default avatarMinchan Kim <minchan@kernel.org>
Acked-by: default avatarJohannes Weiner <hannes@cmpxchg.org>
Acked-by: default avatarVlastimil Babka <vbabka@suse.cz>
Acked-by: default avatarMichal Hocko <mhocko@suse.com>
Cc: Kirill A. Shutemov <kirill@shutemov.name>
Cc: Chen Gang <gang.chen.5i5j@gmail.com>
Cc: Anshuman Khandual <khandual@linux.vnet.ibm.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent 056b9d8a
...@@ -548,7 +548,7 @@ static int __collapse_huge_page_isolate(struct vm_area_struct *vma, ...@@ -548,7 +548,7 @@ static int __collapse_huge_page_isolate(struct vm_area_struct *vma,
* The page must only be referenced by the scanned process * The page must only be referenced by the scanned process
* and page swap cache. * and page swap cache.
*/ */
if (page_count(page) != 1 + !!PageSwapCache(page)) { if (page_count(page) != 1 + PageSwapCache(page)) {
unlock_page(page); unlock_page(page);
result = SCAN_PAGE_COUNT; result = SCAN_PAGE_COUNT;
goto out; goto out;
...@@ -1181,7 +1181,7 @@ static int khugepaged_scan_pmd(struct mm_struct *mm, ...@@ -1181,7 +1181,7 @@ static int khugepaged_scan_pmd(struct mm_struct *mm,
* The page must only be referenced by the scanned process * The page must only be referenced by the scanned process
* and page swap cache. * and page swap cache.
*/ */
if (page_count(page) != 1 + !!PageSwapCache(page)) { if (page_count(page) != 1 + PageSwapCache(page)) {
result = SCAN_PAGE_COUNT; result = SCAN_PAGE_COUNT;
goto out_unmap; goto out_unmap;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment