Commit 2a8a3d5b authored by Eric W. Biederman's avatar Eric W. Biederman Committed by Linus Torvalds

[PATCH] machine_kexec.c: Fix the description of segment handling

One of my original comments in machine_kexec was unclear
and this should fix it.
Signed-off-by: default avatarEric W. Biederman <ebiederm@xmission.com>
Cc: Andi Kleen <ak@muc.de>
Acked-by: default avatarHorms <horms@verge.net.au>
Signed-off-by: default avatarAndrew Morton <akpm@osdl.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@osdl.org>
parent c35a7261
...@@ -189,14 +189,11 @@ NORET_TYPE void machine_kexec(struct kimage *image) ...@@ -189,14 +189,11 @@ NORET_TYPE void machine_kexec(struct kimage *image)
memcpy((void *)reboot_code_buffer, relocate_new_kernel, memcpy((void *)reboot_code_buffer, relocate_new_kernel,
relocate_new_kernel_size); relocate_new_kernel_size);
/* The segment registers are funny things, they are /* The segment registers are funny things, they have both a
* automatically loaded from a table, in memory wherever you * visible and an invisible part. Whenever the visible part is
* set them to a specific selector, but this table is never * set to a specific selector, the invisible part is loaded
* accessed again you set the segment to a different selector. * with from a table in memory. At no other time is the
* * descriptor table in memory accessed.
* The more common model is are caches where the behide
* the scenes work is done, but is also dropped at arbitrary
* times.
* *
* I take advantage of this here by force loading the * I take advantage of this here by force loading the
* segments, before I zap the gdt with an invalid value. * segments, before I zap the gdt with an invalid value.
......
...@@ -207,14 +207,11 @@ NORET_TYPE void machine_kexec(struct kimage *image) ...@@ -207,14 +207,11 @@ NORET_TYPE void machine_kexec(struct kimage *image)
__flush_tlb(); __flush_tlb();
/* The segment registers are funny things, they are /* The segment registers are funny things, they have both a
* automatically loaded from a table, in memory wherever you * visible and an invisible part. Whenever the visible part is
* set them to a specific selector, but this table is never * set to a specific selector, the invisible part is loaded
* accessed again unless you set the segment to a different selector. * with from a table in memory. At no other time is the
* * descriptor table in memory accessed.
* The more common model are caches where the behide
* the scenes work is done, but is also dropped at arbitrary
* times.
* *
* I take advantage of this here by force loading the * I take advantage of this here by force loading the
* segments, before I zap the gdt with an invalid value. * segments, before I zap the gdt with an invalid value.
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment