Commit 2a9b9951 authored by Al Viro's avatar Al Viro

sanitize cifs_umount() prototype

a) superblock argument is unused
b) it always returns 0
Acked-by: default avatarPavel Shilovsky <piastryyy@gmail.com>
Reviewed-by: default avatarJeff Layton <jlayton@redhat.com>
Signed-off-by: default avatarAl Viro <viro@zeniv.linux.org.uk>
parent 2ced6f69
...@@ -172,7 +172,7 @@ cifs_read_super(struct super_block *sb, struct smb_vol *volume_info, ...@@ -172,7 +172,7 @@ cifs_read_super(struct super_block *sb, struct smb_vol *volume_info,
if (inode) if (inode)
iput(inode); iput(inode);
cifs_umount(sb, cifs_sb); cifs_umount(cifs_sb);
return rc; return rc;
} }
...@@ -189,9 +189,7 @@ cifs_put_super(struct super_block *sb) ...@@ -189,9 +189,7 @@ cifs_put_super(struct super_block *sb)
return; return;
} }
rc = cifs_umount(sb, cifs_sb); cifs_umount(cifs_sb);
if (rc)
cERROR(1, "cifs_umount failed with return code %d", rc);
} }
static void cifs_kill_sb(struct super_block *sb) static void cifs_kill_sb(struct super_block *sb)
......
...@@ -158,7 +158,7 @@ extern void cifs_cleanup_volume_info(struct smb_vol **pvolume_info); ...@@ -158,7 +158,7 @@ extern void cifs_cleanup_volume_info(struct smb_vol **pvolume_info);
extern int cifs_setup_volume_info(struct smb_vol **pvolume_info, extern int cifs_setup_volume_info(struct smb_vol **pvolume_info,
char *mount_data, const char *devname); char *mount_data, const char *devname);
extern int cifs_mount(struct cifs_sb_info *, struct smb_vol *); extern int cifs_mount(struct cifs_sb_info *, struct smb_vol *);
extern int cifs_umount(struct super_block *, struct cifs_sb_info *); extern void cifs_umount(struct cifs_sb_info *);
extern void cifs_dfs_release_automount_timer(void); extern void cifs_dfs_release_automount_timer(void);
void cifs_proc_init(void); void cifs_proc_init(void);
void cifs_proc_clean(void); void cifs_proc_clean(void);
......
...@@ -3339,8 +3339,8 @@ CIFSTCon(unsigned int xid, struct cifs_ses *ses, ...@@ -3339,8 +3339,8 @@ CIFSTCon(unsigned int xid, struct cifs_ses *ses,
return rc; return rc;
} }
int void
cifs_umount(struct super_block *sb, struct cifs_sb_info *cifs_sb) cifs_umount(struct cifs_sb_info *cifs_sb)
{ {
struct rb_root *root = &cifs_sb->tlink_tree; struct rb_root *root = &cifs_sb->tlink_tree;
struct rb_node *node; struct rb_node *node;
...@@ -3362,7 +3362,6 @@ cifs_umount(struct super_block *sb, struct cifs_sb_info *cifs_sb) ...@@ -3362,7 +3362,6 @@ cifs_umount(struct super_block *sb, struct cifs_sb_info *cifs_sb)
spin_unlock(&cifs_sb->tlink_tree_lock); spin_unlock(&cifs_sb->tlink_tree_lock);
bdi_destroy(&cifs_sb->bdi); bdi_destroy(&cifs_sb->bdi);
return 0;
} }
int cifs_negotiate_protocol(unsigned int xid, struct cifs_ses *ses) int cifs_negotiate_protocol(unsigned int xid, struct cifs_ses *ses)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment