Commit 2af86f9d authored by Karthik D A's avatar Karthik D A Committed by Kalle Valo

mwifiex: Fix request_irq() failure handling

It's been observed that request_irq() failure leads to a system crash
due to a bug in mwifiex driver.
When this failure happens, mwifiex_add_card() already takes care of
clearing and freeing adapter->card pointer. This patch removes the
redundant cleanup code causing crash.
Signed-off-by: default avatarKarthik D A <karthida@marvell.com>
Signed-off-by: default avatarAmitkumar Karwar <akarwar@marvell.com>
Signed-off-by: default avatarKalle Valo <kvalo@codeaurora.org>
parent fd3ed33f
...@@ -202,7 +202,6 @@ static int mwifiex_pcie_probe(struct pci_dev *pdev, ...@@ -202,7 +202,6 @@ static int mwifiex_pcie_probe(struct pci_dev *pdev,
if (mwifiex_add_card(card, &add_remove_card_sem, &pcie_ops, if (mwifiex_add_card(card, &add_remove_card_sem, &pcie_ops,
MWIFIEX_PCIE)) { MWIFIEX_PCIE)) {
pr_err("%s failed\n", __func__); pr_err("%s failed\n", __func__);
kfree(card);
return -1; return -1;
} }
...@@ -2843,7 +2842,6 @@ static int mwifiex_pcie_request_irq(struct mwifiex_adapter *adapter) ...@@ -2843,7 +2842,6 @@ static int mwifiex_pcie_request_irq(struct mwifiex_adapter *adapter)
"MRVL_PCIE", &card->share_irq_ctx); "MRVL_PCIE", &card->share_irq_ctx);
if (ret) { if (ret) {
pr_err("request_irq failed: ret=%d\n", ret); pr_err("request_irq failed: ret=%d\n", ret);
adapter->card = NULL;
return -1; return -1;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment