Commit 2b7425f3 authored by Hante Meuleman's avatar Hante Meuleman Committed by Kalle Valo

brcmfmac: fix clearing entry IPv6 address

When IPv6 address is to be cleared there is a possible out of
bound access. But also the clearing of the last entry and the
adjustment of total number of stored IPv6 addresses is not
updated. This patch fixes that bug. Bug was found using coverity.
Reviewed-by: default avatarArend Van Spriel <arend.vanspriel@broadcom.com>
Reviewed-by: default avatarFranky Lin <franky.lin@broadcom.com>
Reviewed-by: default avatarPieter-Paul Giesberts <pieter-paul.giesberts@broadcom.com>
Signed-off-by: default avatarHante Meuleman <hante.meuleman@broadcom.com>
Signed-off-by: default avatarArend van Spriel <arend.vanspriel@broadcom.com>
Signed-off-by: default avatarKalle Valo <kvalo@codeaurora.org>
parent 835680b8
......@@ -873,9 +873,12 @@ static int brcmf_inet6addr_changed(struct notifier_block *nb,
}
break;
case NETDEV_DOWN:
if (i < NDOL_MAX_ENTRIES)
for (; i < ifp->ipv6addr_idx; i++)
if (i < NDOL_MAX_ENTRIES) {
for (; i < ifp->ipv6addr_idx - 1; i++)
table[i] = table[i + 1];
memset(&table[i], 0, sizeof(table[i]));
ifp->ipv6addr_idx--;
}
break;
default:
break;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment