Commit 2c798236 authored by Gustavo A. R. Silva's avatar Gustavo A. R. Silva Committed by Martin K. Petersen

scsi: ppa: mark expected switch fall-throughs

In preparation to enabling -Wimplicit-fallthrough, mark switch cases
where we are expecting to fall through.

Addresses-Coverity-ID: 114988
Addresses-Coverity-ID: 114989
Addresses-Coverity-ID: 114990
Addresses-Coverity-ID: 114991
Signed-off-by: default avatarGustavo A. R. Silva <garsilva@embeddedor.com>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent f35cb48e
...@@ -724,6 +724,7 @@ static int ppa_engine(ppa_struct *dev, struct scsi_cmnd *cmd) ...@@ -724,6 +724,7 @@ static int ppa_engine(ppa_struct *dev, struct scsi_cmnd *cmd)
return 0; return 0;
} }
cmd->SCp.phase++; cmd->SCp.phase++;
/* fall through */
case 3: /* Phase 3 - Ready to accept a command */ case 3: /* Phase 3 - Ready to accept a command */
w_ctr(ppb, 0x0c); w_ctr(ppb, 0x0c);
...@@ -733,6 +734,7 @@ static int ppa_engine(ppa_struct *dev, struct scsi_cmnd *cmd) ...@@ -733,6 +734,7 @@ static int ppa_engine(ppa_struct *dev, struct scsi_cmnd *cmd)
if (!ppa_send_command(cmd)) if (!ppa_send_command(cmd))
return 0; return 0;
cmd->SCp.phase++; cmd->SCp.phase++;
/* fall through */
case 4: /* Phase 4 - Setup scatter/gather buffers */ case 4: /* Phase 4 - Setup scatter/gather buffers */
if (scsi_bufflen(cmd)) { if (scsi_bufflen(cmd)) {
...@@ -746,6 +748,7 @@ static int ppa_engine(ppa_struct *dev, struct scsi_cmnd *cmd) ...@@ -746,6 +748,7 @@ static int ppa_engine(ppa_struct *dev, struct scsi_cmnd *cmd)
} }
cmd->SCp.buffers_residual = scsi_sg_count(cmd) - 1; cmd->SCp.buffers_residual = scsi_sg_count(cmd) - 1;
cmd->SCp.phase++; cmd->SCp.phase++;
/* fall through */
case 5: /* Phase 5 - Data transfer stage */ case 5: /* Phase 5 - Data transfer stage */
w_ctr(ppb, 0x0c); w_ctr(ppb, 0x0c);
...@@ -758,6 +761,7 @@ static int ppa_engine(ppa_struct *dev, struct scsi_cmnd *cmd) ...@@ -758,6 +761,7 @@ static int ppa_engine(ppa_struct *dev, struct scsi_cmnd *cmd)
if (retv == 0) if (retv == 0)
return 1; return 1;
cmd->SCp.phase++; cmd->SCp.phase++;
/* fall through */
case 6: /* Phase 6 - Read status/message */ case 6: /* Phase 6 - Read status/message */
cmd->result = DID_OK << 16; cmd->result = DID_OK << 16;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment