Commit 2dccb4cd authored by Petr Matousek's avatar Petr Matousek Committed by Paolo Bonzini

kvm: x86: i8259: return initialized data on invalid-size read

If data is read from PIC with invalid access size, the return data stays
uninitialized even though success is returned.

Fix this by always initializing the data.
Signed-off-by: default avatarPetr Matousek <pmatouse@redhat.com>
Reported-by: default avatarNadav Amit <nadav.amit@gmail.com>
Message-Id: <20150311111609.GG8544@dhcp-25-225.brq.redhat.com>
Signed-off-by: default avatarPaolo Bonzini <pbonzini@redhat.com>
parent 65844bb0
...@@ -507,6 +507,7 @@ static int picdev_read(struct kvm_pic *s, ...@@ -507,6 +507,7 @@ static int picdev_read(struct kvm_pic *s,
return -EOPNOTSUPP; return -EOPNOTSUPP;
if (len != 1) { if (len != 1) {
memset(val, 0, len);
pr_pic_unimpl("non byte read\n"); pr_pic_unimpl("non byte read\n");
return 0; return 0;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment