Commit 2e0cbf2c authored by Thomas Petazzoni's avatar Thomas Petazzoni Committed by David S. Miller

net: mvmdio: add select PHYLIB

The mvmdio driver uses the phylib API, so it should select the PHYLIB
symbol, otherwise, a build with mvmdio (but without mvneta) fails to
build with undefined symbols such as mdiobus_unregister, mdiobus_free,
etc.

The mvneta driver does not use the phylib API directly, so it does not
need to select PHYLIB. It already selects the mvmdio driver anyway.

Historically, this problem is due to the fact that the PHY handling
was originally part of mvneta, and was later moved to a separate
driver, without updating the Kconfig select statements
accordingly. And since there was no functional reason to use mvmdio
without mvneta, this case was not tested.
Signed-off-by: default avatarThomas Petazzoni <thomas.petazzoni@free-electrons.com>
Reported-by: default avatarFengguang Wu <fengguang.wu@intel.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent fb745e9a
...@@ -33,6 +33,7 @@ config MV643XX_ETH ...@@ -33,6 +33,7 @@ config MV643XX_ETH
config MVMDIO config MVMDIO
tristate "Marvell MDIO interface support" tristate "Marvell MDIO interface support"
select PHYLIB
---help--- ---help---
This driver supports the MDIO interface found in the network This driver supports the MDIO interface found in the network
interface units of the Marvell EBU SoCs (Kirkwood, Orion5x, interface units of the Marvell EBU SoCs (Kirkwood, Orion5x,
...@@ -45,7 +46,6 @@ config MVMDIO ...@@ -45,7 +46,6 @@ config MVMDIO
config MVNETA config MVNETA
tristate "Marvell Armada 370/XP network interface support" tristate "Marvell Armada 370/XP network interface support"
depends on MACH_ARMADA_370_XP depends on MACH_ARMADA_370_XP
select PHYLIB
select MVMDIO select MVMDIO
---help--- ---help---
This driver supports the network interface units in the This driver supports the network interface units in the
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment