Commit 34b1fcae authored by Maxime Chevallier's avatar Maxime Chevallier Committed by Mark Brown

spi: a3700: Remove endianness swapping for full-duplex transfers

Fixes the following sparse warnings :
line 767: warning: incorrect type in assignment (different base types)
line 767:    expected unsigned int [unsigned] [assigned] [usertype] val_out
line 767:    got restricted __le32 [usertype] <noident>
line 776: warning: cast to restricted __le32

This takes advantage of readl/writel to do the endianness reordering,
and removes an extra variable in the function.

Fixes: f68a7dcb ("spi: a3700: Add full-duplex support")
Signed-off-by: default avatarMaxime Chevallier <maxime.chevallier@smile.fr>
Reviewed-by: default avatarGregory CLEMENT <gregory.clement@free-electrons.com>
Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent 162f8deb
...@@ -739,7 +739,7 @@ static int a3700_spi_transfer_one_full_duplex(struct spi_master *master, ...@@ -739,7 +739,7 @@ static int a3700_spi_transfer_one_full_duplex(struct spi_master *master,
struct spi_transfer *xfer) struct spi_transfer *xfer)
{ {
struct a3700_spi *a3700_spi = spi_master_get_devdata(master); struct a3700_spi *a3700_spi = spi_master_get_devdata(master);
u32 val_in, val_out; u32 val;
/* Disable FIFO mode */ /* Disable FIFO mode */
a3700_spi_fifo_mode_set(a3700_spi, false); a3700_spi_fifo_mode_set(a3700_spi, false);
...@@ -753,21 +753,20 @@ static int a3700_spi_transfer_one_full_duplex(struct spi_master *master, ...@@ -753,21 +753,20 @@ static int a3700_spi_transfer_one_full_duplex(struct spi_master *master,
a3700_spi_bytelen_set(a3700_spi, 1); a3700_spi_bytelen_set(a3700_spi, 1);
if (a3700_spi->byte_len == 1) if (a3700_spi->byte_len == 1)
val_out = *a3700_spi->tx_buf; val = *a3700_spi->tx_buf;
else else
val_out = cpu_to_le32(*(u32 *)a3700_spi->tx_buf); val = *(u32 *)a3700_spi->tx_buf;
spireg_write(a3700_spi, A3700_SPI_DATA_OUT_REG, val_out); spireg_write(a3700_spi, A3700_SPI_DATA_OUT_REG, val);
/* Wait for all the data to be shifted in / out */ /* Wait for all the data to be shifted in / out */
while (!(spireg_read(a3700_spi, A3700_SPI_IF_CTRL_REG) & while (!(spireg_read(a3700_spi, A3700_SPI_IF_CTRL_REG) &
A3700_SPI_XFER_DONE)) A3700_SPI_XFER_DONE))
cpu_relax(); cpu_relax();
val_in = le32_to_cpu(spireg_read(a3700_spi, val = spireg_read(a3700_spi, A3700_SPI_DATA_IN_REG);
A3700_SPI_DATA_IN_REG));
memcpy(a3700_spi->rx_buf, &val_in, a3700_spi->byte_len); memcpy(a3700_spi->rx_buf, &val, a3700_spi->byte_len);
a3700_spi->buf_len -= a3700_spi->byte_len; a3700_spi->buf_len -= a3700_spi->byte_len;
a3700_spi->tx_buf += a3700_spi->byte_len; a3700_spi->tx_buf += a3700_spi->byte_len;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment