Commit 35a196be authored by Paul Moore's avatar Paul Moore

proc: prevent changes to overridden credentials

Prevent userspace from changing the the /proc/PID/attr values if the
task's credentials are currently overriden.  This not only makes sense
conceptually, it also prevents some really bizarre error cases caused
when trying to commit credentials to a task with overridden
credentials.

Cc: <stable@vger.kernel.org>
Reported-by: default avatar"chengjian (D)" <cj.chengjian@huawei.com>
Signed-off-by: default avatarPaul Moore <paul@paul-moore.com>
Acked-by: default avatarJohn Johansen <john.johansen@canonical.com>
Acked-by: default avatarJames Morris <james.morris@microsoft.com>
Acked-by: default avatarCasey Schaufler <casey@schaufler-ca.com>
parent c750e692
...@@ -2539,6 +2539,11 @@ static ssize_t proc_pid_attr_write(struct file * file, const char __user * buf, ...@@ -2539,6 +2539,11 @@ static ssize_t proc_pid_attr_write(struct file * file, const char __user * buf,
rcu_read_unlock(); rcu_read_unlock();
return -EACCES; return -EACCES;
} }
/* Prevent changes to overridden credentials. */
if (current_cred() != current_real_cred()) {
rcu_read_unlock();
return -EBUSY;
}
rcu_read_unlock(); rcu_read_unlock();
if (count > PAGE_SIZE) if (count > PAGE_SIZE)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment