Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
L
linux
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
linux
Commits
36c72ca2
Commit
36c72ca2
authored
Oct 05, 2003
by
Jens Axboe
Committed by
Linus Torvalds
Oct 05, 2003
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
[PATCH] check copy_from_user return value in sony535
From: Felipe W Damasio <felipewd@terra.com.br> Found by smatch.
parent
fb0dc60d
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
2 additions
and
5 deletions
+2
-5
drivers/cdrom/sonycd535.c
drivers/cdrom/sonycd535.c
+2
-5
No files found.
drivers/cdrom/sonycd535.c
View file @
36c72ca2
...
@@ -1070,7 +1070,6 @@ cdu_ioctl(struct inode *inode,
...
@@ -1070,7 +1070,6 @@ cdu_ioctl(struct inode *inode,
Byte
cmd_buff
[
10
],
params
[
10
];
Byte
cmd_buff
[
10
],
params
[
10
];
int
i
;
int
i
;
int
dsc_status
;
int
dsc_status
;
int
err
;
if
(
check_drive_status
()
!=
0
)
if
(
check_drive_status
()
!=
0
)
return
-
EIO
;
return
-
EIO
;
...
@@ -1153,12 +1152,10 @@ cdu_ioctl(struct inode *inode,
...
@@ -1153,12 +1152,10 @@ cdu_ioctl(struct inode *inode,
break
;
break
;
case
CDROMPLAYMSF
:
/* Play starting at the given MSF address. */
case
CDROMPLAYMSF
:
/* Play starting at the given MSF address. */
err
=
verify_area
(
VERIFY_READ
,
(
char
*
)
arg
,
6
);
if
(
copy_from_user
(
params
,
(
void
*
)
arg
,
6
))
if
(
err
)
return
-
EFAULT
;
return
err
;
spin_up_drive
(
status
);
spin_up_drive
(
status
);
set_drive_mode
(
SONY535_AUDIO_DRIVE_MODE
,
status
);
set_drive_mode
(
SONY535_AUDIO_DRIVE_MODE
,
status
);
copy_from_user
(
params
,
(
void
*
)
arg
,
6
);
/* The parameters are given in int, must be converted */
/* The parameters are given in int, must be converted */
for
(
i
=
0
;
i
<
3
;
i
++
)
{
for
(
i
=
0
;
i
<
3
;
i
++
)
{
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment