Commit 36f31a70 authored by Krzysztof Helt's avatar Krzysztof Helt Committed by Linus Torvalds

s3c2410fb: removes lcdcon1 register value from s3c2410fb_display

This patch removes lcdcon1 register field from the s3c2410fb_display as all
bits are calculated from other fields.
Signed-off-by: default avatarKrzysztof Helt <krzysztof.h1@wp.pl>
Signed-off-by: default avatarAntonino Daplas <adaplas@gmail.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent 69816699
...@@ -184,7 +184,6 @@ static struct s3c2410fb_display __initdata amlm5900_lcd_info = { ...@@ -184,7 +184,6 @@ static struct s3c2410fb_display __initdata amlm5900_lcd_info = {
.upper_margin = 0, .upper_margin = 0,
.lower_margin = 0, .lower_margin = 0,
.lcdcon1 = 0x00008225,
.lcdcon5 = 0x00000001, .lcdcon5 = 0x00000001,
}; };
......
...@@ -484,7 +484,6 @@ static struct s3c2410fb_display __initdata bast_lcd_info[] = { ...@@ -484,7 +484,6 @@ static struct s3c2410fb_display __initdata bast_lcd_info[] = {
.lower_margin = 32, .lower_margin = 32,
.vsync_len = 3, .vsync_len = 3,
.lcdcon1 = 0x00000176,
.lcdcon5 = 0x00014b02, .lcdcon5 = 0x00014b02,
}, },
{ {
...@@ -503,7 +502,6 @@ static struct s3c2410fb_display __initdata bast_lcd_info[] = { ...@@ -503,7 +502,6 @@ static struct s3c2410fb_display __initdata bast_lcd_info[] = {
.lower_margin = 32, .lower_margin = 32,
.vsync_len = 3, .vsync_len = 3,
.lcdcon1 = 0x00000176,
.lcdcon5 = 0x00014b02, .lcdcon5 = 0x00014b02,
}, },
{ {
...@@ -522,7 +520,6 @@ static struct s3c2410fb_display __initdata bast_lcd_info[] = { ...@@ -522,7 +520,6 @@ static struct s3c2410fb_display __initdata bast_lcd_info[] = {
.lower_margin = 32, .lower_margin = 32,
.vsync_len = 3, .vsync_len = 3,
.lcdcon1 = 0x00000176,
.lcdcon5 = 0x00014b02, .lcdcon5 = 0x00014b02,
}, },
}; };
......
...@@ -134,10 +134,6 @@ static struct s3c2410_udc_mach_info h1940_udc_cfg __initdata = { ...@@ -134,10 +134,6 @@ static struct s3c2410_udc_mach_info h1940_udc_cfg __initdata = {
* Set lcd on or off * Set lcd on or off
**/ **/
static struct s3c2410fb_display h1940_lcd __initdata = { static struct s3c2410fb_display h1940_lcd __initdata = {
.lcdcon1= S3C2410_LCDCON1_TFT16BPP | \
S3C2410_LCDCON1_TFT | \
S3C2410_LCDCON1_CLKVAL(0x0C),
.lcdcon5= S3C2410_LCDCON5_FRM565 | \ .lcdcon5= S3C2410_LCDCON5_FRM565 | \
S3C2410_LCDCON5_INVVLINE | \ S3C2410_LCDCON5_INVVLINE | \
S3C2410_LCDCON5_HWSWP, S3C2410_LCDCON5_HWSWP,
......
...@@ -98,10 +98,6 @@ static struct s3c2410_uartcfg smdk2410_uartcfgs[] = { ...@@ -98,10 +98,6 @@ static struct s3c2410_uartcfg smdk2410_uartcfgs[] = {
static struct s3c2410fb_display qt2410_lcd_cfg[] __initdata = { static struct s3c2410fb_display qt2410_lcd_cfg[] __initdata = {
{ {
/* Configuration for 640x480 SHARP LQ080V3DG01 */ /* Configuration for 640x480 SHARP LQ080V3DG01 */
.lcdcon1 = S3C2410_LCDCON1_TFT16BPP |
S3C2410_LCDCON1_TFT |
S3C2410_LCDCON1_CLKVAL(0x01), /* HCLK/4 */
.lcdcon5 = S3C2410_LCDCON5_FRM565 | .lcdcon5 = S3C2410_LCDCON5_FRM565 |
S3C2410_LCDCON5_INVVLINE | S3C2410_LCDCON5_INVVLINE |
S3C2410_LCDCON5_INVVFRAME | S3C2410_LCDCON5_INVVFRAME |
...@@ -125,10 +121,6 @@ static struct s3c2410fb_display qt2410_lcd_cfg[] __initdata = { ...@@ -125,10 +121,6 @@ static struct s3c2410fb_display qt2410_lcd_cfg[] __initdata = {
}, },
{ {
/* Configuration for 480x640 toppoly TD028TTEC1 */ /* Configuration for 480x640 toppoly TD028TTEC1 */
.lcdcon1 = S3C2410_LCDCON1_TFT16BPP |
S3C2410_LCDCON1_TFT |
S3C2410_LCDCON1_CLKVAL(0x01), /* HCLK/4 */
.lcdcon5 = S3C2410_LCDCON5_FRM565 | .lcdcon5 = S3C2410_LCDCON5_FRM565 |
S3C2410_LCDCON5_INVVLINE | S3C2410_LCDCON5_INVVLINE |
S3C2410_LCDCON5_INVVFRAME | S3C2410_LCDCON5_INVVFRAME |
...@@ -151,10 +143,6 @@ static struct s3c2410fb_display qt2410_lcd_cfg[] __initdata = { ...@@ -151,10 +143,6 @@ static struct s3c2410fb_display qt2410_lcd_cfg[] __initdata = {
}, },
{ {
/* Config for 240x320 LCD */ /* Config for 240x320 LCD */
.lcdcon1 = S3C2410_LCDCON1_TFT16BPP |
S3C2410_LCDCON1_TFT |
S3C2410_LCDCON1_CLKVAL(0x04),
.lcdcon5 = S3C2410_LCDCON5_FRM565 | .lcdcon5 = S3C2410_LCDCON5_FRM565 |
S3C2410_LCDCON5_INVVLINE | S3C2410_LCDCON5_INVVLINE |
S3C2410_LCDCON5_INVVFRAME | S3C2410_LCDCON5_INVVFRAME |
......
...@@ -111,10 +111,6 @@ static struct s3c2410_uartcfg rx3715_uartcfgs[] = { ...@@ -111,10 +111,6 @@ static struct s3c2410_uartcfg rx3715_uartcfgs[] = {
/* framebuffer lcd controller information */ /* framebuffer lcd controller information */
static struct s3c2410fb_display rx3715_lcdcfg __initdata = { static struct s3c2410fb_display rx3715_lcdcfg __initdata = {
.lcdcon1 = S3C2410_LCDCON1_TFT16BPP | \
S3C2410_LCDCON1_TFT | \
S3C2410_LCDCON1_CLKVAL(0x0C),
.lcdcon5 = S3C2410_LCDCON5_INVVLINE | .lcdcon5 = S3C2410_LCDCON5_INVVLINE |
S3C2410_LCDCON5_FRM565 | S3C2410_LCDCON5_FRM565 |
S3C2410_LCDCON5_HWSWP, S3C2410_LCDCON5_HWSWP,
......
...@@ -105,10 +105,6 @@ static struct s3c2410_uartcfg smdk2440_uartcfgs[] __initdata = { ...@@ -105,10 +105,6 @@ static struct s3c2410_uartcfg smdk2440_uartcfgs[] __initdata = {
static struct s3c2410fb_display smdk2440_lcd_cfg __initdata = { static struct s3c2410fb_display smdk2440_lcd_cfg __initdata = {
.lcdcon1 = S3C2410_LCDCON1_TFT16BPP |
S3C2410_LCDCON1_TFT |
S3C2410_LCDCON1_CLKVAL(0x04),
.lcdcon5 = S3C2410_LCDCON5_FRM565 | .lcdcon5 = S3C2410_LCDCON5_FRM565 |
S3C2410_LCDCON5_INVVLINE | S3C2410_LCDCON5_INVVLINE |
S3C2410_LCDCON5_INVVFRAME | S3C2410_LCDCON5_INVVFRAME |
......
...@@ -207,11 +207,9 @@ static int s3c2410fb_check_var(struct fb_var_screeninfo *var, ...@@ -207,11 +207,9 @@ static int s3c2410fb_check_var(struct fb_var_screeninfo *var,
var->vsync_len = display->vsync_len; var->vsync_len = display->vsync_len;
var->hsync_len = display->hsync_len; var->hsync_len = display->hsync_len;
fbi->regs.lcdcon1 = display->lcdcon1;
fbi->regs.lcdcon5 = display->lcdcon5; fbi->regs.lcdcon5 = display->lcdcon5;
/* set display type */ /* set display type */
fbi->regs.lcdcon1 &= ~S3C2410_LCDCON1_TFT; fbi->regs.lcdcon1 = display->type;
fbi->regs.lcdcon1 |= display->type;
var->transp.offset = 0; var->transp.offset = 0;
var->transp.length = 0; var->transp.length = 0;
...@@ -301,8 +299,6 @@ static void s3c2410fb_calculate_stn_lcd_regs(const struct fb_info *info, ...@@ -301,8 +299,6 @@ static void s3c2410fb_calculate_stn_lcd_regs(const struct fb_info *info,
if (type != S3C2410_LCDCON1_STN4) if (type != S3C2410_LCDCON1_STN4)
hs >>= 1; hs >>= 1;
regs->lcdcon1 &= ~S3C2410_LCDCON1_MODEMASK;
switch (var->bits_per_pixel) { switch (var->bits_per_pixel) {
case 1: case 1:
regs->lcdcon1 |= S3C2410_LCDCON1_STN1BPP; regs->lcdcon1 |= S3C2410_LCDCON1_STN1BPP;
...@@ -356,8 +352,6 @@ static void s3c2410fb_calculate_tft_lcd_regs(const struct fb_info *info, ...@@ -356,8 +352,6 @@ static void s3c2410fb_calculate_tft_lcd_regs(const struct fb_info *info,
const struct s3c2410fb_info *fbi = info->par; const struct s3c2410fb_info *fbi = info->par;
const struct fb_var_screeninfo *var = &info->var; const struct fb_var_screeninfo *var = &info->var;
regs->lcdcon1 &= ~S3C2410_LCDCON1_MODEMASK;
switch (var->bits_per_pixel) { switch (var->bits_per_pixel) {
case 1: case 1:
regs->lcdcon1 |= S3C2410_LCDCON1_TFT1BPP; regs->lcdcon1 |= S3C2410_LCDCON1_TFT1BPP;
...@@ -437,7 +431,6 @@ static void s3c2410fb_activate_var(struct fb_info *info) ...@@ -437,7 +431,6 @@ static void s3c2410fb_activate_var(struct fb_info *info)
clkdiv = 2; clkdiv = 2;
} }
fbi->regs.lcdcon1 &= ~S3C2410_LCDCON1_CLKVAL(0x3ff);
fbi->regs.lcdcon1 |= S3C2410_LCDCON1_CLKVAL(clkdiv); fbi->regs.lcdcon1 |= S3C2410_LCDCON1_CLKVAL(clkdiv);
/* write new registers */ /* write new registers */
......
...@@ -45,7 +45,6 @@ struct s3c2410fb_display { ...@@ -45,7 +45,6 @@ struct s3c2410fb_display {
unsigned short vsync_len; /* value in lines (TFT) or 0 (STN) */ unsigned short vsync_len; /* value in lines (TFT) or 0 (STN) */
/* lcd configuration registers */ /* lcd configuration registers */
unsigned long lcdcon1;
unsigned long lcdcon5; unsigned long lcdcon5;
}; };
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment