Commit 379ebf07 authored by Dan Carpenter's avatar Dan Carpenter Committed by Anna Schumaker

NFS: silence a harmless uninitialized variable warning

kstrtoul() can return -ERANGE so Smatch complains that "num" can be
uninitialized.  We check that it's within bounds so it's not a huge
deal.
Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarAnna Schumaker <Anna.Schumaker@Netapp.com>
parent 016583d7
...@@ -2899,7 +2899,7 @@ static int param_set_portnr(const char *val, const struct kernel_param *kp) ...@@ -2899,7 +2899,7 @@ static int param_set_portnr(const char *val, const struct kernel_param *kp)
if (!val) if (!val)
return -EINVAL; return -EINVAL;
ret = kstrtoul(val, 0, &num); ret = kstrtoul(val, 0, &num);
if (ret == -EINVAL || num > NFS_CALLBACK_MAXPORTNR) if (ret || num > NFS_CALLBACK_MAXPORTNR)
return -EINVAL; return -EINVAL;
*((unsigned int *)kp->arg) = num; *((unsigned int *)kp->arg) = num;
return 0; return 0;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment