Commit 37febd0f authored by David S. Miller's avatar David S. Miller Committed by Vojtech Pavlik

I did find one bug, hid_submit_ctrl() does not cpu_to_le16()

all the control request fields properly.
parent 458dbf65
...@@ -1073,7 +1073,7 @@ static int hid_submit_ctrl(struct hid_device *hid) ...@@ -1073,7 +1073,7 @@ static int hid_submit_ctrl(struct hid_device *hid)
hid->cr.bRequestType = USB_TYPE_CLASS | USB_RECIP_INTERFACE | dir; hid->cr.bRequestType = USB_TYPE_CLASS | USB_RECIP_INTERFACE | dir;
hid->cr.bRequest = (dir == USB_DIR_OUT) ? HID_REQ_SET_REPORT : HID_REQ_GET_REPORT; hid->cr.bRequest = (dir == USB_DIR_OUT) ? HID_REQ_SET_REPORT : HID_REQ_GET_REPORT;
hid->cr.wValue = ((report->type + 1) << 8) | report->id; hid->cr.wValue = cpu_to_le16(((report->type + 1) << 8) | report->id);
hid->cr.wIndex = cpu_to_le16(hid->ifnum); hid->cr.wIndex = cpu_to_le16(hid->ifnum);
hid->cr.wLength = cpu_to_le16(hid->urbctrl->transfer_buffer_length); hid->cr.wLength = cpu_to_le16(hid->urbctrl->transfer_buffer_length);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment