Commit 396e36c9 authored by Tim Sell's avatar Tim Sell Committed by Greg Kroah-Hartman

staging: unisys: visorbus: relocate error-check from isr to registration

It just makes more sense to do the NULL-pointer check when the function is
called to enable interrupts, rather than on *every* interrupt.
Signed-off-by: default avatarTim Sell <Timothy.Sell@unisys.com>
Signed-off-by: default avatarDavid Kershner <david.kershner@unisys.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent db2003f5
...@@ -438,8 +438,7 @@ dev_periodic_work(unsigned long __opaque) ...@@ -438,8 +438,7 @@ dev_periodic_work(unsigned long __opaque)
struct visor_device *dev = (struct visor_device *)__opaque; struct visor_device *dev = (struct visor_device *)__opaque;
struct visor_driver *drv = to_visor_driver(dev->device.driver); struct visor_driver *drv = to_visor_driver(dev->device.driver);
if (drv->channel_interrupt) drv->channel_interrupt(dev);
drv->channel_interrupt(dev);
mod_timer(&dev->timer, jiffies + POLLJIFFIES_NORMALCHANNEL); mod_timer(&dev->timer, jiffies + POLLJIFFIES_NORMALCHANNEL);
} }
...@@ -561,6 +560,13 @@ EXPORT_SYMBOL_GPL(visorbus_write_channel); ...@@ -561,6 +560,13 @@ EXPORT_SYMBOL_GPL(visorbus_write_channel);
void void
visorbus_enable_channel_interrupts(struct visor_device *dev) visorbus_enable_channel_interrupts(struct visor_device *dev)
{ {
struct visor_driver *drv = to_visor_driver(dev->device.driver);
if (!drv->channel_interrupt) {
dev_err(&dev->device, "%s no interrupt function!\n", __func__);
return;
}
dev_start_periodic_work(dev); dev_start_periodic_work(dev);
} }
EXPORT_SYMBOL_GPL(visorbus_enable_channel_interrupts); EXPORT_SYMBOL_GPL(visorbus_enable_channel_interrupts);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment