Commit 3b5f307e authored by Junxiao Bi's avatar Junxiao Bi Committed by Martin K. Petersen

scsi: megaraid_sas: fix panic on loading firmware crashdump

While loading fw crashdump in function fw_crash_buffer_show(), left bytes
in one dma chunk was not checked, if copying size over it, overflow access
will cause kernel panic.
Signed-off-by: default avatarJunxiao Bi <junxiao.bi@oracle.com>
Acked-by: default avatarSumit Saxena <sumit.saxena@broadcom.com>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent 359603a3
...@@ -3163,6 +3163,7 @@ fw_crash_buffer_show(struct device *cdev, ...@@ -3163,6 +3163,7 @@ fw_crash_buffer_show(struct device *cdev,
(struct megasas_instance *) shost->hostdata; (struct megasas_instance *) shost->hostdata;
u32 size; u32 size;
unsigned long dmachunk = CRASH_DMA_BUF_SIZE; unsigned long dmachunk = CRASH_DMA_BUF_SIZE;
unsigned long chunk_left_bytes;
unsigned long src_addr; unsigned long src_addr;
unsigned long flags; unsigned long flags;
u32 buff_offset; u32 buff_offset;
...@@ -3186,6 +3187,8 @@ fw_crash_buffer_show(struct device *cdev, ...@@ -3186,6 +3187,8 @@ fw_crash_buffer_show(struct device *cdev,
} }
size = (instance->fw_crash_buffer_size * dmachunk) - buff_offset; size = (instance->fw_crash_buffer_size * dmachunk) - buff_offset;
chunk_left_bytes = dmachunk - (buff_offset % dmachunk);
size = (size > chunk_left_bytes) ? chunk_left_bytes : size;
size = (size >= PAGE_SIZE) ? (PAGE_SIZE - 1) : size; size = (size >= PAGE_SIZE) ? (PAGE_SIZE - 1) : size;
src_addr = (unsigned long)instance->crash_buf[buff_offset / dmachunk] + src_addr = (unsigned long)instance->crash_buf[buff_offset / dmachunk] +
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment