Commit 3c28b913 authored by Andreas Pape's avatar Andreas Pape Committed by Mauro Carvalho Chehab

media: stkwebcam: Bugfix for wrong return values

usb_control_msg returns in case of a successfully sent message the number
of sent bytes as a positive number. Don't use this value as a return value
for stk_camera_read_reg, as a non-zero return value is used as an error
condition in some cases when stk_camera_read_reg is called.
Signed-off-by: default avatarAndreas Pape <ap@ca-pape.de>
Reviewed-by: default avatarKieran Bingham <kieran.bingham@ideasonboard.com>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab+samsung@kernel.org>
parent 2bf47eef
...@@ -171,7 +171,11 @@ int stk_camera_read_reg(struct stk_camera *dev, u16 index, u8 *value) ...@@ -171,7 +171,11 @@ int stk_camera_read_reg(struct stk_camera *dev, u16 index, u8 *value)
*value = *buf; *value = *buf;
kfree(buf); kfree(buf);
return ret;
if (ret < 0)
return ret;
else
return 0;
} }
static int stk_start_stream(struct stk_camera *dev) static int stk_start_stream(struct stk_camera *dev)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment