[PATCH] fix file_lock_cache leak

Always free the request, not just on error.

[PATCH] fix file_lock_cache leak
Always free the request, not just on error.
3c4cb3be · Matthew Wilcox · Linus Torvalds · 156889a0 · 3c4cb3be
Commit 3c4cb3be authored Sep 26, 2002 by Matthew Wilcox Committed by Linus Torvalds Sep 26, 2002
Hide whitespace changes
Inline Side-by-side

Showing with 3 additions and 8 deletions

fs/locks.c fs/locks.c +3 -8

No files found.
--- a/fs/locks.c
+++ b/fs/locks.c
@@ -1459,10 +1459,8 @@ int fcntl_setlk(struct file *filp, unsigned int cmd, struct flock *l)
 		break;
 	}

-out:
-	if (error) {
-		locks_free_lock(file_lock);
-	}
+ out:
+	locks_free_lock(file_lock);
 	return error;
 }

@@ -1601,11 +1599,8 @@ int fcntl_setlk64(struct file *filp, unsigned int cmd, struct flock64 *l)
 		break;
 	}

-
 out:
-	if (error) {
-		locks_free_lock(file_lock);
-	}
+	locks_free_lock(file_lock);
 	return error;
 }
 #endif /* BITS_PER_LONG == 32 */