Commit 3d2557ab authored by Nishka Dasgupta's avatar Nishka Dasgupta Committed by Krzysztof Kozlowski

pinctrl: samsung: Add of_node_put() before return in error path

Each iteration of for_each_child_of_node puts the previous node, but in
the case of a return from the middle of the loop, there is no put, thus
causing a memory leak. Hence add an of_node_put before the return of
exynos_eint_wkup_init() error path.
Issue found with Coccinelle.
Signed-off-by: default avatarNishka Dasgupta <nishkadg.linux@gmail.com>
Cc: <stable@vger.kernel.org>
Fixes: 14c255d3 ("pinctrl: exynos: Add irq_chip instance for Exynos7 wakeup interrupts")
Signed-off-by: default avatarKrzysztof Kozlowski <krzk@kernel.org>
parent 54ecb8f7
...@@ -486,8 +486,10 @@ int exynos_eint_wkup_init(struct samsung_pinctrl_drv_data *d) ...@@ -486,8 +486,10 @@ int exynos_eint_wkup_init(struct samsung_pinctrl_drv_data *d)
if (match) { if (match) {
irq_chip = kmemdup(match->data, irq_chip = kmemdup(match->data,
sizeof(*irq_chip), GFP_KERNEL); sizeof(*irq_chip), GFP_KERNEL);
if (!irq_chip) if (!irq_chip) {
of_node_put(np);
return -ENOMEM; return -ENOMEM;
}
wkup_np = np; wkup_np = np;
break; break;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment