Commit 3e2c1592 authored by Johannes Berg's avatar Johannes Berg

iwlwifi: clarify NOCOPY/DUP documentation

Clarify the documentation to indicate that these
flags can only be used at the end, i.e. after them
a copy TFD (no flags set) is invalid.
Reported-by: default avatarInbal Hacohen <inbal.hacohen@intel.com>
Reviewed-by: default avatarEmmanuel Grumbach <emmanuel.grumbach@intel.com>
Signed-off-by: default avatarJohannes Berg <johannes.berg@intel.com>
parent f4feb8ac
...@@ -225,10 +225,13 @@ struct iwl_device_cmd { ...@@ -225,10 +225,13 @@ struct iwl_device_cmd {
* ring. The transport layer doesn't map the command's buffer to DMA, but * ring. The transport layer doesn't map the command's buffer to DMA, but
* rather copies it to an previously allocated DMA buffer. This flag tells * rather copies it to an previously allocated DMA buffer. This flag tells
* the transport layer not to copy the command, but to map the existing * the transport layer not to copy the command, but to map the existing
* buffer. This can save memcpy and is worth with very big comamnds. * buffer (that is passed in) instead. This saves the memcpy and allows
* commands that are bigger than the fixed buffer to be submitted.
* Note that a TFD entry after a NOCOPY one cannot be a normal copied one.
* @IWL_HCMD_DFL_DUP: Only valid without NOCOPY, duplicate the memory for this * @IWL_HCMD_DFL_DUP: Only valid without NOCOPY, duplicate the memory for this
* chunk internally and free it again after the command completes. This * chunk internally and free it again after the command completes. This
* can (currently) be used only once per command. * can (currently) be used only once per command.
* Note that a TFD entry after a DUP one cannot be a normal copied one.
*/ */
enum iwl_hcmd_dataflag { enum iwl_hcmd_dataflag {
IWL_HCMD_DFL_NOCOPY = BIT(0), IWL_HCMD_DFL_NOCOPY = BIT(0),
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment