Commit 3fe0fd53 authored by Jacob Keller's avatar Jacob Keller Committed by David S. Miller

netdevsim: support taking immediate snapshot via devlink

Implement the .snapshot region operation for the dummy data region. This
enables a region snapshot to be taken upon request via the new
DEVLINK_CMD_REGION_SNAPSHOT command.
Signed-off-by: default avatarJacob Keller <jacob.e.keller@intel.com>
Reviewed-by: default avatarJiri Pirko <jiri@mellanox.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent b9a17abf
...@@ -39,23 +39,38 @@ static struct dentry *nsim_dev_ddir; ...@@ -39,23 +39,38 @@ static struct dentry *nsim_dev_ddir;
#define NSIM_DEV_DUMMY_REGION_SIZE (1024 * 32) #define NSIM_DEV_DUMMY_REGION_SIZE (1024 * 32)
static int
nsim_dev_take_snapshot(struct devlink *devlink, struct netlink_ext_ack *extack,
u8 **data)
{
void *dummy_data;
dummy_data = kmalloc(NSIM_DEV_DUMMY_REGION_SIZE, GFP_KERNEL);
if (!dummy_data)
return -ENOMEM;
get_random_bytes(dummy_data, NSIM_DEV_DUMMY_REGION_SIZE);
*data = dummy_data;
return 0;
}
static ssize_t nsim_dev_take_snapshot_write(struct file *file, static ssize_t nsim_dev_take_snapshot_write(struct file *file,
const char __user *data, const char __user *data,
size_t count, loff_t *ppos) size_t count, loff_t *ppos)
{ {
struct nsim_dev *nsim_dev = file->private_data; struct nsim_dev *nsim_dev = file->private_data;
struct devlink *devlink; struct devlink *devlink;
void *dummy_data; u8 *dummy_data;
int err; int err;
u32 id; u32 id;
devlink = priv_to_devlink(nsim_dev); devlink = priv_to_devlink(nsim_dev);
dummy_data = kmalloc(NSIM_DEV_DUMMY_REGION_SIZE, GFP_KERNEL); err = nsim_dev_take_snapshot(devlink, NULL, &dummy_data);
if (!dummy_data) if (err)
return -ENOMEM; return err;
get_random_bytes(dummy_data, NSIM_DEV_DUMMY_REGION_SIZE);
err = devlink_region_snapshot_id_get(devlink, &id); err = devlink_region_snapshot_id_get(devlink, &id);
if (err) { if (err) {
...@@ -351,6 +366,7 @@ static void nsim_devlink_param_load_driverinit_values(struct devlink *devlink) ...@@ -351,6 +366,7 @@ static void nsim_devlink_param_load_driverinit_values(struct devlink *devlink)
static const struct devlink_region_ops dummy_region_ops = { static const struct devlink_region_ops dummy_region_ops = {
.name = "dummy", .name = "dummy",
.destructor = &kfree, .destructor = &kfree,
.snapshot = nsim_dev_take_snapshot,
}; };
static int nsim_dev_dummy_region_init(struct nsim_dev *nsim_dev, static int nsim_dev_dummy_region_init(struct nsim_dev *nsim_dev,
......
...@@ -141,6 +141,16 @@ regions_test() ...@@ -141,6 +141,16 @@ regions_test()
check_region_snapshot_count dummy post-first-delete 2 check_region_snapshot_count dummy post-first-delete 2
devlink region new $DL_HANDLE/dummy snapshot 25
check_err $? "Failed to create a new snapshot with id 25"
check_region_snapshot_count dummy post-first-request 3
devlink region del $DL_HANDLE/dummy snapshot 25
check_err $? "Failed to delete snapshot with id 25"
check_region_snapshot_count dummy post-second-delete 2
log_test "regions test" log_test "regions test"
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment