Commit 40ad5b37 authored by Shawn Guo's avatar Shawn Guo

dmaengine: imx-sdma: sdma_get_firmware does not need to copy fw_name

It does not need to allocate space and copy fw_name in function
sdma_get_firmware().
Signed-off-by: default avatarShawn Guo <shawn.guo@linaro.org>
Cc: Vinod Koul <vinod.koul@intel.com>
Cc: Sascha Hauer <s.hauer@pengutronix.de>
Acked-by: default avatarVinod Koul <vinod.koul@intel.com>
parent 62550cd7
...@@ -1126,22 +1126,14 @@ static int __init sdma_get_firmware(struct sdma_engine *sdma, ...@@ -1126,22 +1126,14 @@ static int __init sdma_get_firmware(struct sdma_engine *sdma,
const char *fw_name) const char *fw_name)
{ {
const struct firmware *fw; const struct firmware *fw;
char *fwname;
const struct sdma_firmware_header *header; const struct sdma_firmware_header *header;
int ret; int ret;
const struct sdma_script_start_addrs *addr; const struct sdma_script_start_addrs *addr;
unsigned short *ram_code; unsigned short *ram_code;
fwname = kasprintf(GFP_KERNEL, "%s", fw_name); ret = request_firmware(&fw, fw_name, sdma->dev);
if (!fwname) if (ret)
return -ENOMEM;
ret = request_firmware(&fw, fwname, sdma->dev);
if (ret) {
kfree(fwname);
return ret; return ret;
}
kfree(fwname);
if (fw->size < sizeof(*header)) if (fw->size < sizeof(*header))
goto err_firmware; goto err_firmware;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment