Commit 411b67b4 authored by Kostik Belousov's avatar Kostik Belousov Committed by Chris Wright

[PATCH] readv/writev syscalls are not checked by lsm

it seems that readv(2)/writev(2) syscalls do not call
file_permission callback. Looks like this is overlook.

I have filled the issue into redhat bugzilla as
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=169433
and got the recommendation to post this on lsm mailing list.

The following trivial patch solves the problem.
Signed-off-by: default avatarKostik Belousov <kostikbel@gmail.com>
Signed-off-by: default avatarChris Wright <chrisw@osdl.org>
parent aa55a086
...@@ -497,6 +497,9 @@ static ssize_t do_readv_writev(int type, struct file *file, ...@@ -497,6 +497,9 @@ static ssize_t do_readv_writev(int type, struct file *file,
} }
ret = rw_verify_area(type, file, pos, tot_len); ret = rw_verify_area(type, file, pos, tot_len);
if (ret)
goto out;
ret = security_file_permission(file, type == READ ? MAY_READ : MAY_WRITE);
if (ret) if (ret)
goto out; goto out;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment