Commit 4169591f authored by Dan Carpenter's avatar Dan Carpenter Committed by David S. Miller

pxa168_eth: remove unneeded null check

"pep->pd" isn't checked consistently in this function.  For example it's
dereferenced unconditionally on the next line after the end of the if
condition.  This function is only called from pxa168_eth_probe() and
pep->pd is always non-NULL so I removed the check.
Signed-off-by: default avatarDan Carpenter <error27@gmail.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent ef24b16b
...@@ -1414,10 +1414,8 @@ static int ethernet_phy_setup(struct net_device *dev) ...@@ -1414,10 +1414,8 @@ static int ethernet_phy_setup(struct net_device *dev)
{ {
struct pxa168_eth_private *pep = netdev_priv(dev); struct pxa168_eth_private *pep = netdev_priv(dev);
if (pep->pd != NULL) { if (pep->pd->init)
if (pep->pd->init) pep->pd->init();
pep->pd->init();
}
pep->phy = phy_scan(pep, pep->pd->phy_addr & 0x1f); pep->phy = phy_scan(pep, pep->pd->phy_addr & 0x1f);
if (pep->phy != NULL) if (pep->phy != NULL)
phy_init(pep, pep->pd->speed, pep->pd->duplex); phy_init(pep, pep->pd->speed, pep->pd->duplex);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment