Commit 4218091c authored by Christian Borntraeger's avatar Christian Borntraeger

mips/gup: Replace ACCESS_ONCE with READ_ONCE

ACCESS_ONCE does not work reliably on non-scalar types. For
example gcc 4.6 and 4.7 might remove the volatile tag for such
accesses during the SRA (scalar replacement of aggregates) step
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=58145)

Change the gup code to replace ACCESS_ONCE with READ_ONCE.
Signed-off-by: default avatarChristian Borntraeger <borntraeger@de.ibm.com>
Acked-by: default avatarPaul E. McKenney <paulmck@linux.vnet.ibm.com>
parent 14cf3d97
...@@ -30,7 +30,7 @@ static inline pte_t gup_get_pte(pte_t *ptep) ...@@ -30,7 +30,7 @@ static inline pte_t gup_get_pte(pte_t *ptep)
return pte; return pte;
#else #else
return ACCESS_ONCE(*ptep); return READ_ONCE(*ptep);
#endif #endif
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment