Commit 43c4eb03 authored by Greg Kroah-Hartman's avatar Greg Kroah-Hartman Committed by David S. Miller

i40e: no need to check return value of debugfs_create functions

When calling debugfs functions, there is no need to ever check the
return value.  The function can work or not, but the code logic should
never do something different based on this.

Cc: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Cc: "David S. Miller" <davem@davemloft.net>
Cc: intel-wired-lan@lists.osuosl.org
Cc: netdev@vger.kernel.org
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent ecc55707
...@@ -1732,29 +1732,15 @@ static const struct file_operations i40e_dbg_netdev_ops_fops = { ...@@ -1732,29 +1732,15 @@ static const struct file_operations i40e_dbg_netdev_ops_fops = {
**/ **/
void i40e_dbg_pf_init(struct i40e_pf *pf) void i40e_dbg_pf_init(struct i40e_pf *pf)
{ {
struct dentry *pfile;
const char *name = pci_name(pf->pdev); const char *name = pci_name(pf->pdev);
const struct device *dev = &pf->pdev->dev;
pf->i40e_dbg_pf = debugfs_create_dir(name, i40e_dbg_root); pf->i40e_dbg_pf = debugfs_create_dir(name, i40e_dbg_root);
if (!pf->i40e_dbg_pf)
return;
pfile = debugfs_create_file("command", 0600, pf->i40e_dbg_pf, pf,
&i40e_dbg_command_fops);
if (!pfile)
goto create_failed;
pfile = debugfs_create_file("netdev_ops", 0600, pf->i40e_dbg_pf, pf, debugfs_create_file("command", 0600, pf->i40e_dbg_pf, pf,
&i40e_dbg_netdev_ops_fops); &i40e_dbg_command_fops);
if (!pfile)
goto create_failed;
return; debugfs_create_file("netdev_ops", 0600, pf->i40e_dbg_pf, pf,
&i40e_dbg_netdev_ops_fops);
create_failed:
dev_info(dev, "debugfs dir/file for %s failed\n", name);
debugfs_remove_recursive(pf->i40e_dbg_pf);
} }
/** /**
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment