Commit 43c70ad5 authored by Linus Lüssing's avatar Linus Lüssing Committed by Marek Lindner

batman-adv: Increase orig_node refcount before releasing rcu read lock

When unicast_send_skb() is increasing the orig_node's refcount another
thread might have been freeing this orig_node already. We need to
increase the refcount in the rcu read lock protected area to avoid that.
Signed-off-by: default avatarLinus Lüssing <linus.luessing@ascom.ch>
Signed-off-by: default avatarMarek Lindner <lindner_marek@yahoo.de>
parent 5d02b3cd
...@@ -54,6 +54,9 @@ void *gw_get_selected(struct bat_priv *bat_priv) ...@@ -54,6 +54,9 @@ void *gw_get_selected(struct bat_priv *bat_priv)
orig_node = curr_gateway_tmp->orig_node; orig_node = curr_gateway_tmp->orig_node;
if (orig_node)
kref_get(&orig_node->refcount);
out: out:
rcu_read_unlock(); rcu_read_unlock();
return orig_node; return orig_node;
......
...@@ -293,10 +293,9 @@ int unicast_send_skb(struct sk_buff *skb, struct bat_priv *bat_priv) ...@@ -293,10 +293,9 @@ int unicast_send_skb(struct sk_buff *skb, struct bat_priv *bat_priv)
spin_lock_bh(&bat_priv->orig_hash_lock); spin_lock_bh(&bat_priv->orig_hash_lock);
/* get routing information */ /* get routing information */
if (is_multicast_ether_addr(ethhdr->h_dest)) if (is_multicast_ether_addr(ethhdr->h_dest)) {
orig_node = (struct orig_node *)gw_get_selected(bat_priv); orig_node = (struct orig_node *)gw_get_selected(bat_priv);
if (orig_node) { if (orig_node)
kref_get(&orig_node->refcount);
goto find_router; goto find_router;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment