Commit 44d303eb authored by Joe Perches's avatar Joe Perches Committed by Linus Torvalds

checkpatch: improve Gerrit Change-Id: test

The Gerrit Change-Id: entry is sometimes placed after a Signed-off-by:
line.  When this occurs, the Gerrit warning is not currently emitted as
the first Signed-off-by: signature sets a flag to stop looking.

Change the test to add a test for the --- patch separator and emit the
warning before any before the --- and also before any diff file name.
Signed-off-by: default avatarJoe Perches <joe@perches.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Tested-by: default avatarJohn Stultz <john.stultz@linaro.org>
Link: http://lkml.kernel.org/r/2f6d5f8766fe7439a116c77ea8cc721a3f2d77a2.camel@perches.comSigned-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent 713a09de
...@@ -2335,6 +2335,7 @@ sub process { ...@@ -2335,6 +2335,7 @@ sub process {
my $is_binding_patch = -1; my $is_binding_patch = -1;
my $in_header_lines = $file ? 0 : 1; my $in_header_lines = $file ? 0 : 1;
my $in_commit_log = 0; #Scanning lines before patch my $in_commit_log = 0; #Scanning lines before patch
my $has_patch_separator = 0; #Found a --- line
my $has_commit_log = 0; #Encountered lines before patch my $has_commit_log = 0; #Encountered lines before patch
my $commit_log_lines = 0; #Number of commit log lines my $commit_log_lines = 0; #Number of commit log lines
my $commit_log_possible_stack_dump = 0; my $commit_log_possible_stack_dump = 0;
...@@ -2660,6 +2661,12 @@ sub process { ...@@ -2660,6 +2661,12 @@ sub process {
} }
} }
# Check for patch separator
if ($line =~ /^---$/) {
$has_patch_separator = 1;
$in_commit_log = 0;
}
# Check if MAINTAINERS is being updated. If so, there's probably no need to # Check if MAINTAINERS is being updated. If so, there's probably no need to
# emit the "does MAINTAINERS need updating?" message on file add/move/delete # emit the "does MAINTAINERS need updating?" message on file add/move/delete
if ($line =~ /^\s*MAINTAINERS\s*\|/) { if ($line =~ /^\s*MAINTAINERS\s*\|/) {
...@@ -2759,10 +2766,10 @@ sub process { ...@@ -2759,10 +2766,10 @@ sub process {
"A patch subject line should describe the change not the tool that found it\n" . $herecurr); "A patch subject line should describe the change not the tool that found it\n" . $herecurr);
} }
# Check for unwanted Gerrit info # Check for Gerrit Change-Ids not in any patch context
if ($in_commit_log && $line =~ /^\s*change-id:/i) { if ($realfile eq '' && !$has_patch_separator && $line =~ /^\s*change-id:/i) {
ERROR("GERRIT_CHANGE_ID", ERROR("GERRIT_CHANGE_ID",
"Remove Gerrit Change-Id's before submitting upstream.\n" . $herecurr); "Remove Gerrit Change-Id's before submitting upstream\n" . $herecurr);
} }
# Check if the commit log is in a possible stack dump # Check if the commit log is in a possible stack dump
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment