Commit 45a77138 authored by Larry Finger's avatar Larry Finger Committed by John W. Linville

rtlwifi: rtl8192de: Fix error exit from hw_init

In routine rtl92de_hw_init(), there are two places where a failure is
not handled correctly.
Reported-by: default avatarDan Carpenter <error27@gmail.com>
Signed-off-by: default avatarLarry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: default avatarJohn W. Linville <linville@tuxdriver.com>
parent eb8b27ad
...@@ -932,8 +932,8 @@ int rtl92de_hw_init(struct ieee80211_hw *hw) ...@@ -932,8 +932,8 @@ int rtl92de_hw_init(struct ieee80211_hw *hw)
RT_TRACE(rtlpriv, COMP_ERR, DBG_WARNING, RT_TRACE(rtlpriv, COMP_ERR, DBG_WARNING,
("Failed to download FW. Init HW " ("Failed to download FW. Init HW "
"without FW..\n")); "without FW..\n"));
err = 1;
rtlhal->fw_ready = false; rtlhal->fw_ready = false;
return 1;
} else { } else {
rtlhal->fw_ready = true; rtlhal->fw_ready = true;
} }
...@@ -1044,6 +1044,11 @@ int rtl92de_hw_init(struct ieee80211_hw *hw) ...@@ -1044,6 +1044,11 @@ int rtl92de_hw_init(struct ieee80211_hw *hw)
if (((tmp_rega & BIT(11)) == BIT(11))) if (((tmp_rega & BIT(11)) == BIT(11)))
break; break;
} }
/* check that loop was successful. If not, exit now */
if (i == 10000) {
rtlpci->init_ready = false;
return 1;
}
} }
} }
rtlpci->init_ready = true; rtlpci->init_ready = true;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment