Commit 4605f057 authored by Wenchao Hao's avatar Wenchao Hao Committed by Linus Torvalds

mm/mempolicy.c: check parameters first in kernel_get_mempolicy

Previous implementatoin calls untagged_addr() before error check, while if
the error check failed and return EINVAL, the untagged_addr() call is just
useless work.
Signed-off-by: default avatarWenchao Hao <haowenchao22@gmail.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Reviewed-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Link: http://lkml.kernel.org/r/20200801090825.5597-1-haowenchao22@gmail.comSigned-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent f6e92f40
...@@ -1632,11 +1632,11 @@ static int kernel_get_mempolicy(int __user *policy, ...@@ -1632,11 +1632,11 @@ static int kernel_get_mempolicy(int __user *policy,
int pval; int pval;
nodemask_t nodes; nodemask_t nodes;
addr = untagged_addr(addr);
if (nmask != NULL && maxnode < nr_node_ids) if (nmask != NULL && maxnode < nr_node_ids)
return -EINVAL; return -EINVAL;
addr = untagged_addr(addr);
err = do_get_mempolicy(&pval, &nodes, addr, flags); err = do_get_mempolicy(&pval, &nodes, addr, flags);
if (err) if (err)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment