Commit 46ee7c3c authored by Oliver O'Halloran's avatar Oliver O'Halloran Committed by Michael Ellerman

powerpc/eeh: Use debugfs_create_u32 for eeh_max_freezes

There's no need to the custom getter/setter functions so we should remove
them in favour of using the generic one. While we're here, change the type
of eeh_max_freeze to u32 and print the value in decimal rather than
hex because printing it in hex makes no sense.
Signed-off-by: default avatarOliver O'Halloran <oohall@gmail.com>
Reviewed-by: default avatarSam Bobroff <sbobroff@linux.ibm.com>
Signed-off-by: default avatarMichael Ellerman <mpe@ellerman.id.au>
parent d065ee93
...@@ -219,7 +219,7 @@ struct eeh_ops { ...@@ -219,7 +219,7 @@ struct eeh_ops {
}; };
extern int eeh_subsystem_flags; extern int eeh_subsystem_flags;
extern int eeh_max_freezes; extern u32 eeh_max_freezes;
extern struct eeh_ops *eeh_ops; extern struct eeh_ops *eeh_ops;
extern raw_spinlock_t confirm_error_lock; extern raw_spinlock_t confirm_error_lock;
......
...@@ -109,7 +109,7 @@ EXPORT_SYMBOL(eeh_subsystem_flags); ...@@ -109,7 +109,7 @@ EXPORT_SYMBOL(eeh_subsystem_flags);
* frozen count in last hour exceeds this limit, the PE will * frozen count in last hour exceeds this limit, the PE will
* be forced to be offline permanently. * be forced to be offline permanently.
*/ */
int eeh_max_freezes = 5; u32 eeh_max_freezes = 5;
/* Platform dependent EEH operations */ /* Platform dependent EEH operations */
struct eeh_ops *eeh_ops = NULL; struct eeh_ops *eeh_ops = NULL;
...@@ -1829,22 +1829,8 @@ static int eeh_enable_dbgfs_get(void *data, u64 *val) ...@@ -1829,22 +1829,8 @@ static int eeh_enable_dbgfs_get(void *data, u64 *val)
return 0; return 0;
} }
static int eeh_freeze_dbgfs_set(void *data, u64 val)
{
eeh_max_freezes = val;
return 0;
}
static int eeh_freeze_dbgfs_get(void *data, u64 *val)
{
*val = eeh_max_freezes;
return 0;
}
DEFINE_DEBUGFS_ATTRIBUTE(eeh_enable_dbgfs_ops, eeh_enable_dbgfs_get, DEFINE_DEBUGFS_ATTRIBUTE(eeh_enable_dbgfs_ops, eeh_enable_dbgfs_get,
eeh_enable_dbgfs_set, "0x%llx\n"); eeh_enable_dbgfs_set, "0x%llx\n");
DEFINE_DEBUGFS_ATTRIBUTE(eeh_freeze_dbgfs_ops, eeh_freeze_dbgfs_get,
eeh_freeze_dbgfs_set, "0x%llx\n");
#endif #endif
static int __init eeh_init_proc(void) static int __init eeh_init_proc(void)
...@@ -1855,9 +1841,8 @@ static int __init eeh_init_proc(void) ...@@ -1855,9 +1841,8 @@ static int __init eeh_init_proc(void)
debugfs_create_file_unsafe("eeh_enable", 0600, debugfs_create_file_unsafe("eeh_enable", 0600,
powerpc_debugfs_root, NULL, powerpc_debugfs_root, NULL,
&eeh_enable_dbgfs_ops); &eeh_enable_dbgfs_ops);
debugfs_create_file_unsafe("eeh_max_freezes", 0600, debugfs_create_u32("eeh_max_freezes", 0600,
powerpc_debugfs_root, NULL, powerpc_debugfs_root, &eeh_max_freezes);
&eeh_freeze_dbgfs_ops);
#endif #endif
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment