Commit 47f1241e authored by Gustavo A. R. Silva's avatar Gustavo A. R. Silva Committed by Herbert Xu

crypto: atmel-tdes - remove unnecessary static in atmel_tdes_remove()

Remove unnecessary static on local variable tdes_dd. Such variable
is initialized before being used, on every execution path throughout
the function. The static has no benefit and, removing it reduces the
object file size.

This issue was detected using Coccinelle and the following semantic patch:
https://github.com/GustavoARSilva/coccinelle/blob/master/static/static_unused.cocci

In the following log you can see a significant difference in the object
file size. This log is the output of the size command, before and after
the code change:

before:
   text    data     bss     dec     hex filename
  17079    8704     128   25911    6537 drivers/crypto/atmel-tdes.o

after:
   text    data     bss     dec     hex filename
  17039    8616      64   25719    6477 drivers/crypto/atmel-tdes.o
Signed-off-by: default avatarGustavo A. R. Silva <gustavo@embeddedor.com>
Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
parent 22d96f04
...@@ -1487,7 +1487,7 @@ static int atmel_tdes_probe(struct platform_device *pdev) ...@@ -1487,7 +1487,7 @@ static int atmel_tdes_probe(struct platform_device *pdev)
static int atmel_tdes_remove(struct platform_device *pdev) static int atmel_tdes_remove(struct platform_device *pdev)
{ {
static struct atmel_tdes_dev *tdes_dd; struct atmel_tdes_dev *tdes_dd;
tdes_dd = platform_get_drvdata(pdev); tdes_dd = platform_get_drvdata(pdev);
if (!tdes_dd) if (!tdes_dd)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment