Commit 481a7d64 authored by Tejun Heo's avatar Tejun Heo Committed by Jens Axboe

block: fix drain_all condition in blk_drain_queue()

When trying to drain all requests, blk_drain_queue() checked only
q->rq.count[]; however, this only tracks REQ_ALLOCED requests.  This
patch updates blk_drain_queue() such that it looks at all the counters
and queues so that request_queue is actually empty on completion.
Signed-off-by: default avatarTejun Heo <tj@kernel.org>
Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
parent 34f6055c
...@@ -358,7 +358,8 @@ EXPORT_SYMBOL(blk_put_queue); ...@@ -358,7 +358,8 @@ EXPORT_SYMBOL(blk_put_queue);
void blk_drain_queue(struct request_queue *q, bool drain_all) void blk_drain_queue(struct request_queue *q, bool drain_all)
{ {
while (true) { while (true) {
int nr_rqs; bool drain = false;
int i;
spin_lock_irq(q->queue_lock); spin_lock_irq(q->queue_lock);
...@@ -368,14 +369,25 @@ void blk_drain_queue(struct request_queue *q, bool drain_all) ...@@ -368,14 +369,25 @@ void blk_drain_queue(struct request_queue *q, bool drain_all)
__blk_run_queue(q); __blk_run_queue(q);
if (drain_all) drain |= q->rq.elvpriv;
nr_rqs = q->rq.count[0] + q->rq.count[1];
else /*
nr_rqs = q->rq.elvpriv; * Unfortunately, requests are queued at and tracked from
* multiple places and there's no single counter which can
* be drained. Check all the queues and counters.
*/
if (drain_all) {
drain |= !list_empty(&q->queue_head);
for (i = 0; i < 2; i++) {
drain |= q->rq.count[i];
drain |= q->in_flight[i];
drain |= !list_empty(&q->flush_queue[i]);
}
}
spin_unlock_irq(q->queue_lock); spin_unlock_irq(q->queue_lock);
if (!nr_rqs) if (!drain)
break; break;
msleep(10); msleep(10);
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment