Commit 4a5fa359 authored by James Bottomley's avatar James Bottomley Committed by James Bottomley

[PARISC] slub: fix panic with DISCONTIGMEM

Slub makes assumptions about page_to_nid() which are violated by
DISCONTIGMEM and !NUMA.  This violation results in a panic because
page_to_nid() can be non-zero for pages in the discontiguous ranges and
this leads to a null return by get_node().  The assertion by the
maintainer is that DISCONTIGMEM should only be allowed when NUMA is also
defined.  However, at least six architectures: alpha, ia64, m32r, m68k,
mips, parisc violate this.  The panic is a regression against slab, so
just mark slub broken in the problem configuration to prevent users
reporting these panics.

Cc: stable@kernel.org
Acked-by: default avatarDavid Rientjes <rientjes@google.com>
Acked-by: default avatarPekka Enberg <penberg@kernel.org>
Signed-off-by: default avatarJames Bottomley <James.Bottomley@suse.de>
parent d9b41e0b
...@@ -1226,6 +1226,7 @@ config SLAB ...@@ -1226,6 +1226,7 @@ config SLAB
per cpu and per node queues. per cpu and per node queues.
config SLUB config SLUB
depends on BROKEN || NUMA || !DISCONTIGMEM
bool "SLUB (Unqueued Allocator)" bool "SLUB (Unqueued Allocator)"
help help
SLUB is a slab allocator that minimizes cache line usage SLUB is a slab allocator that minimizes cache line usage
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment