Commit 4b28038f authored by Vladimir Zapolskiy's avatar Vladimir Zapolskiy Committed by Bjorn Andersson

remoteproc: st: fix check of syscon_regmap_lookup_by_phandle() return value

syscon_regmap_lookup_by_phandle() returns either a valid pointer to
struct regmap or ERR_PTR() error value, check for NULL is invalid and
on error path may lead to oops, the change corrects the check.
Signed-off-by: default avatarVladimir Zapolskiy <vz@mleia.com>
Acked-by: default avatarLee Jones <lee.jones@linaro.org>
Signed-off-by: default avatarBjorn Andersson <bjorn.andersson@linaro.org>
parent f55532a0
...@@ -189,9 +189,9 @@ static int st_rproc_parse_dt(struct platform_device *pdev) ...@@ -189,9 +189,9 @@ static int st_rproc_parse_dt(struct platform_device *pdev)
} }
ddata->boot_base = syscon_regmap_lookup_by_phandle(np, "st,syscfg"); ddata->boot_base = syscon_regmap_lookup_by_phandle(np, "st,syscfg");
if (!ddata->boot_base) { if (IS_ERR(ddata->boot_base)) {
dev_err(dev, "Boot base not found\n"); dev_err(dev, "Boot base not found\n");
return -EINVAL; return PTR_ERR(ddata->boot_base);
} }
err = of_property_read_u32_index(np, "st,syscfg", 1, err = of_property_read_u32_index(np, "st,syscfg", 1,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment