Commit 4bab6909 authored by Chaitanya Kulkarni's avatar Chaitanya Kulkarni Committed by Christoph Hellwig

nvme-core: put ctrl ref when module ref get fail

When try_module_get() fails in the nvme_dev_open() it returns without
releasing the ctrl reference which was taken earlier.

Put the ctrl reference which is taken before calling the
try_module_get() in the error return code path.

Fixes: 52a3974f "nvme-core: get/put ctrl and transport module in nvme_dev_open/release()"
Signed-off-by: default avatarChaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
Reviewed-by: default avatarLogan Gunthorpe <logang@deltatee.com>
Signed-off-by: default avatarChristoph Hellwig <hch@lst.de>
parent 6d53a9fe
...@@ -3265,8 +3265,10 @@ static int nvme_dev_open(struct inode *inode, struct file *file) ...@@ -3265,8 +3265,10 @@ static int nvme_dev_open(struct inode *inode, struct file *file)
} }
nvme_get_ctrl(ctrl); nvme_get_ctrl(ctrl);
if (!try_module_get(ctrl->ops->module)) if (!try_module_get(ctrl->ops->module)) {
nvme_put_ctrl(ctrl);
return -EINVAL; return -EINVAL;
}
file->private_data = ctrl; file->private_data = ctrl;
return 0; return 0;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment