Commit 4caf4ebf authored by Linus Torvalds's avatar Linus Torvalds

Fix access_ok() fallout for sparc32 and powerpc

These two architectures actually had an intentional use of the 'type'
argument to access_ok() just to avoid warnings.

I had actually noticed the powerpc one, but forgot to then fix it up.
And I missed the sparc32 case entirely.

This is hopefully all of it.
Reported-by: default avatarMathieu Malaterre <malat@debian.org>
Reported-by: default avatarGuenter Roeck <linux@roeck-us.net>
Fixes: 96d4f267 ("Remove 'type' argument from access_ok() function")
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent 96d4f267
...@@ -63,7 +63,7 @@ static inline int __access_ok(unsigned long addr, unsigned long size, ...@@ -63,7 +63,7 @@ static inline int __access_ok(unsigned long addr, unsigned long size,
#endif #endif
#define access_ok(addr, size) \ #define access_ok(addr, size) \
(__chk_user_ptr(addr), (void)(type), \ (__chk_user_ptr(addr), \
__access_ok((__force unsigned long)(addr), (size), get_fs())) __access_ok((__force unsigned long)(addr), (size), get_fs()))
/* /*
......
...@@ -39,8 +39,7 @@ ...@@ -39,8 +39,7 @@
#define __user_ok(addr, size) ({ (void)(size); (addr) < STACK_TOP; }) #define __user_ok(addr, size) ({ (void)(size); (addr) < STACK_TOP; })
#define __kernel_ok (uaccess_kernel()) #define __kernel_ok (uaccess_kernel())
#define __access_ok(addr, size) (__user_ok((addr) & get_fs().seg, (size))) #define __access_ok(addr, size) (__user_ok((addr) & get_fs().seg, (size)))
#define access_ok(addr, size) \ #define access_ok(addr, size) __access_ok((unsigned long)(addr), size)
({ (void)(type); __access_ok((unsigned long)(addr), size); })
/* /*
* The exception table consists of pairs of addresses: the first is the * The exception table consists of pairs of addresses: the first is the
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment